chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/extensions/extension_install_ui_default.cc ('k') | chrome/browser/ui/find_bar/find_bar_host_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc

diff --git a/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc b/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc

index e6e73fed0925283c3c017161c3796ef5679f6ab3..7f655bc97970c89450e95ec344790112be759150 100644

--- a/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc

+++ b/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc

@@ -45,8 +45,7 @@ void ExtensionMessageBubbleBrowserTest::TestBubbleAnchoredToExtensionAction() {

extensions::Manifest::UNPACKED);

extension_service()->AddExtension(action_extension.get());

- Browser* second_browser = new Browser(

- Browser::CreateParams(profile(), browser()->host_desktop_type()));

+ Browser* second_browser = new Browser(Browser::CreateParams(profile()));

base::RunLoop().RunUntilIdle();

CheckBubble(second_browser, ANCHOR_BROWSER_ACTION);

@@ -61,8 +60,7 @@ void ExtensionMessageBubbleBrowserTest::TestBubbleAnchoredToAppMenu() {

extensions::Manifest::UNPACKED);

extension_service()->AddExtension(no_action_extension.get());

- Browser* second_browser = new Browser(

- Browser::CreateParams(profile(), browser()->host_desktop_type()));

+ Browser* second_browser = new Browser(Browser::CreateParams(profile()));

base::RunLoop().RunUntilIdle();

CheckBubble(second_browser, ANCHOR_APP_MENU);

@@ -85,8 +83,7 @@ void ExtensionMessageBubbleBrowserTest::

extensions::Manifest::INTERNAL);

extension_service()->AddExtension(action_extension.get());

- Browser* second_browser = new Browser(

- Browser::CreateParams(profile(), browser()->host_desktop_type()));

+ Browser* second_browser = new Browser(Browser::CreateParams(profile()));

base::RunLoop().RunUntilIdle();

CheckBubble(second_browser, ANCHOR_APP_MENU);

@@ -105,8 +102,7 @@ void ExtensionMessageBubbleBrowserTest::TestUninstallDangerousExtension() {

// Create a second browser with the extension installed - the bubble will be

// set to show.

- Browser* second_browser = new Browser(

- Browser::CreateParams(profile(), browser()->host_desktop_type()));

+ Browser* second_browser = new Browser(Browser::CreateParams(profile()));

ASSERT_TRUE(second_browser);

// Uninstall the extension before the bubble is shown. This should not crash,

// and the bubble shouldn't be shown.