chrome/browser/ui/chrome_pages.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/chrome_pages.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_tab_strip_model_delegate.cc ('k') | chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/chrome_pages.cc

diff --git a/chrome/browser/ui/chrome_pages.cc b/chrome/browser/ui/chrome_pages.cc

index 5ba3f711dc197b9dd701b23dc7757b00eb67a500..3e16b17a1b210da5e9c9a349e5690aafa53c8ea8 100644

--- a/chrome/browser/ui/chrome_pages.cc

+++ b/chrome/browser/ui/chrome_pages.cc

@@ -124,8 +124,7 @@ void ShowHelpImpl(Browser* browser,

}

scoped_ptr<ScopedTabbedBrowserDisplayer> displayer;

if (!browser) {

- displayer.reset(

- new ScopedTabbedBrowserDisplayer(profile, host_desktop_type));

+ displayer.reset(new ScopedTabbedBrowserDisplayer(profile));

browser = displayer->browser();

}

ShowSingletonTab(browser, url);

@@ -287,8 +286,7 @@ void ShowSettingsSubPageForProfile(Profile* profile,

}

Browser* browser = chrome::FindTabbedBrowser(profile, false);

if (!browser) {

- browser = new Browser(

- Browser::CreateParams(profile, chrome::HOST_DESKTOP_TYPE_NATIVE));

+ browser = new Browser(Browser::CreateParams(profile));

}

ShowSettingsSubPageInTabbedBrowser(browser, sub_page);

}

@@ -372,8 +370,7 @@ void ShowBrowserSignin(Browser* browser,

scoped_ptr<ScopedTabbedBrowserDisplayer> displayer;

if (browser->profile()->IsOffTheRecord()) {

switched_browser = true;

- displayer.reset(new ScopedTabbedBrowserDisplayer(

- original_profile, chrome::HOST_DESKTOP_TYPE_NATIVE));

+ displayer.reset(new ScopedTabbedBrowserDisplayer(original_profile));

browser = displayer->browser();

}