Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1662733003: Add a v2 closure gyp syntax to Closure wiki (Closed)

Created:
4 years, 10 months ago by Dan Beam
Modified:
4 years, 10 months ago
Reviewers:
hcarmona
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a v2 closure gyp syntax to Closure wiki R=hcarmona@chromium.org BUG=none NOTRY=true Committed: https://crrev.com/e3d03b7c1ff4b14ce72474b50e4a52bcd732b54e Cr-Commit-Position: refs/heads/master@{#374002}

Patch Set 1 : 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M docs/closure_compilation.md View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Dan Beam
4 years, 10 months ago (2016-02-06 01:26:17 UTC) #2
hcarmona
lgtm
4 years, 10 months ago (2016-02-06 01:54:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662733003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662733003/20001
4 years, 10 months ago (2016-02-06 03:03:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 10 months ago (2016-02-06 03:08:34 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-06 03:09:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3d03b7c1ff4b14ce72474b50e4a52bcd732b54e
Cr-Commit-Position: refs/heads/master@{#374002}

Powered by Google App Engine
This is Rietveld 408576698