docs/closure_compilation.md - Issue 1662733003: Add a v2 closure gyp syntax to Closure wiki

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: docs/closure_compilation.md

Issue 1662733003: Add a v2 closure gyp syntax to Closure wiki (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: docs/closure_compilation.md

diff --git a/docs/closure_compilation.md b/docs/closure_compilation.md

index 4f403cdea60bf295a9aa492c6d32dc56a456b869..2f0907ab2c82a2675ab38d53fa580e603fdbba70 100644

--- a/docs/closure_compilation.md

+++ b/docs/closure_compilation.md

@@ -7,8 +7,15 @@ To locally run closure compiler like the bots, do this:

```shell

cd $CHROMIUM_SRC

# sudo apt-get install openjdk-7-jre # may be required

-GYP_GENERATORS=ninja tools/gyp/gyp --depth . \

-third_party/closure_compiler/compiled_resources.gyp

+GYP_GENERATORS=ninja tools/gyp/gyp --depth . third_party/closure_compiler/compiled_resources.gyp

+ninja -C out/Default

+```

+To run the v2 gyp format, change the last 2 lines to:

+```shell

+# notice the 2 in compiled_resources2.gyp

+GYP_GENERATORS=ninja tools/gyp/gyp --depth . third_party/closure_compiler/compiled_resources2.gyp

ninja -C out/Default

```

« no previous file with comments | « no previous file | no next file » | no next file with comments »