Issue 166273026: Implement the encrypt-then-MAC TLS extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 166273026: Implement the encrypt-then-MAC TLS extension. (Closed)

Created:
6 years, 10 months ago by wtc

Modified:
6 years, 10 months ago

Reviewers:
Deprecated (see juliatuttle)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[For reference only. DO NOT CHECK THIS IN.] Implement the encrypt-then-MAC TLS extension. This implements the -05 draft at http://tools.ietf.org/html/draft-gutmann-tls-encrypt-then-mac-05 Note that the test server at https://eid.vx4.net:443/ uses the extension_type value of 0x42 (decimal 66). Also, the test server passes the length of TLSCiphertext.fragment (excluding the length of MAC), rather than TLSCipherText.length, to the MAC function. The -05 draft specifies TLSCipherText.length should be passed. This CL passes the same wrong length to interoperate with the test server. Upstream NSS bug: https://bugzilla.mozilla.org/show_bug.cgi?id=972145 R=ttuttle@chromium.org BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : Remove nss_ssl_util.cc from the CL #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+159 lines, -19 lines)			Patch
M	net/socket/ssl_client_socket_nss.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	net/third_party/nss/ssl/ssl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/third_party/nss/ssl/ssl3con.c	View	12 chunks	+78 lines, -16 lines	0 comments	Download
M	net/third_party/nss/ssl/ssl3ext.c	View	4 chunks	+56 lines, -1 line	0 comments	Download
M	net/third_party/nss/ssl/sslimpl.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	net/third_party/nss/ssl/sslsock.c	View	5 chunks	+14 lines, -1 line	0 comments	Download
M	net/third_party/nss/ssl/sslt.h	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

This CL is for reference only. I will close it.

Expand Messages | Collapse Messages