Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 166273019: Add rotateRadians function to AffineTransform (Closed)

Created:
6 years, 10 months ago by zino
Modified:
6 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add rotateRadians function to AffineTransform Currently, rotate function takes an argument in only degrees. In many cases, rotate function is often required radian value instead of degree value. If we add new rotateRadians function, we will be able to reduce unnecessary operations. Before : rad -> rad2deg -> deg2rad -> calc sinNcos After : rad -> calc sinNcos As a result, we can reduce two multiplication and two division. Similar case: https://bugs.webkit.org/show_bug.cgi?id=87317 Applications: https://codereview.chromium.org/173593002/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M Source/platform/transforms/AffineTransform.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/transforms/AffineTransform.cpp View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
zino
6 years, 10 months ago (2014-02-20 11:38:14 UTC) #1
Justin Novosad
On 2014/02/20 11:38:14, zino wrote: lgtm
6 years, 10 months ago (2014-02-20 19:31:18 UTC) #2
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 10 months ago (2014-02-21 08:30:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/166273019/1
6 years, 10 months ago (2014-02-21 08:31:05 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 10:31:05 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=19448
6 years, 10 months ago (2014-02-21 10:31:05 UTC) #6
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 10 months ago (2014-02-21 13:22:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/166273019/1
6 years, 10 months ago (2014-02-21 13:22:39 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 16:18:22 UTC) #9
Message was sent while issue was closed.
Change committed as 167603

Powered by Google App Engine
This is Rietveld 408576698