Source/core/inspector/InspectorLayerTreeAgent.h - Issue 166273018: Added showing slow scroll rectangles in Layers panel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorLayerTreeAgent.h

Issue 166273018: Added showing slow scroll rectangles in Layers panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Moved ScrollRects into Layer structure. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/inspector/layers/layer-scroll-rects-update.html ('K') | « LayoutTests/inspector/layers/layer-scroll-rects-update-expected.txt ('k') | Source/core/inspector/InspectorLayerTreeAgent.cpp » ('j') | Source/devtools/front_end/LayerTreeModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorLayerTreeAgent.h

diff --git a/Source/core/inspector/InspectorLayerTreeAgent.h b/Source/core/inspector/InspectorLayerTreeAgent.h

index 6aca73ab88a59001540d18d795dbb6fd7fb2450b..cf0e12fae43c67dc073e9d6cf497738dfca8a6c0 100644

--- a/Source/core/inspector/InspectorLayerTreeAgent.h

+++ b/Source/core/inspector/InspectorLayerTreeAgent.h

@@ -88,11 +88,11 @@ private:

RenderLayerCompositor* renderLayerCompositor();

GraphicsLayer* layerById(ErrorString*, const String& layerId);

const LayerSnapshot* snapshotById(ErrorString*, const String& snapshotId);

- PassRefPtr<TypeBuilder::Array<TypeBuilder::LayerTree::Layer> > buildLayerTree();

+ bool buildLayerTree(TypeBuilder::Array<TypeBuilder::LayerTree::Layer>&);

caseq 2014/02/27 13:46:55 I think you can revert this to original signature

malch 2014/02/27 14:58:59 Done.

typedef HashMap<int, int> LayerIdToNodeIdMap;

void buildLayerIdToNodeIdMap(RenderLayer*, LayerIdToNodeIdMap&);

- void gatherGraphicsLayers(GraphicsLayer*, HashMap<int, int>& layerIdToNodeIdMap, RefPtr<TypeBuilder::Array<TypeBuilder::LayerTree::Layer> >&);

+ void gatherGraphicsLayers(GraphicsLayer*, HashMap<int, int>& layerIdToNodeIdMap, TypeBuilder::Array<TypeBuilder::LayerTree::Layer>&);

int idForNode(Node*);

InspectorFrontend::LayerTree* m_frontend;