Issue 166273004: Check that Filter::Factory doesn't crash if SDCH is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 166273004: Check that Filter::Factory doesn't crash if SDCH is disabled. (Closed)

Created:
6 years, 10 months ago by mef

Modified:
6 years, 7 months ago

Reviewers:
cbentzel, andrea, jar (doing other things), huey

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Check that Filter::Factory doesn't crash if SDCH is disabled. Unit test for https://codereview.chromium.org/138533008. TEST=out/Debug/net_unittests --gtest_filter=FilterTest.FilterFactoryWithDisabledSDCHSupport BUG=167218

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	M	net/filter/filter_unittest.cc	View		2 chunks	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mef

Hi, I've added a unit test for https://codereview.chromium.org/138533008. Two strange observations: - I don't see ...

6 years, 10 months ago (2014-02-14 19:36:49 UTC) #1

cbentzel

I'm worried that we didn't see the crash/segfault without the previous CL - that this ...

6 years, 10 months ago (2014-02-18 19:54:34 UTC) #2

huey

6 years, 9 months ago (2014-03-04 21:36:16 UTC) #3

After reverting my initial change in a local client, I am no longer able to
repro the crash. I was able to in early January, though, so I'm guessing
that something was fixed in the past few months.

On Tue, Feb 18, 2014 at 11:54 AM, <cbentzel@chromium.org> wrote:

> I'm worried that we didn't see the crash/segfault without the previous CL
> - that
> this isn't testing the right thing.
>
> https://codereview.chromium.org/166273004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages