Check that Filter::Factory doesn't crash if SDCH is disabled.

net/filter/filter_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "net/base/sdch_manager.h"
 #include "net/filter/filter.h"
 #include "net/filter/mock_filter_context.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 class FilterTest : public testing::Test {
 };
 
 TEST(FilterTest, ContentTypeId) {
@@ skipping 325 matching lines @@
   // Except on downloads, where they just get saved.
   encoding_types.clear();
   encoding_types.push_back(Filter::FILTER_TYPE_GZIP);
   filter_context.SetDownload(true);
   filter_context.SetMimeType(kHtmlMime);
   filter_context.SetURL(GURL(kGzUrl));
   Filter::FixupEncodingTypes(filter_context, &encoding_types);
   EXPECT_TRUE(encoding_types.empty());
 }
 
+// Check that Filter::Factory doesn't crash if SDCH is disabled.
+TEST(FilterTest, FilterFactoryWithDisabledSDCHSupport) {
+  MockFilterContext filter_context;
+
+  // Disable SDCH support
+  SdchManager::EnableSdchSupport(false);
+  EXPECT_TRUE(SdchManager::Global() == NULL);
+  EXPECT_FALSE(SdchManager::sdch_enabled());
+
+  std::vector<Filter::FilterType> encoding_types;
+  Filter* filter;
+
+  // Adding just GZIP should provide valid filter.
+  encoding_types.clear();
+  encoding_types.push_back(Filter::FILTER_TYPE_GZIP);
+  filter = Filter::Factory(encoding_types, filter_context);
+  ASSERT_TRUE(filter != NULL);
+
+  // Adding just SDCH should provide NULL filter.
+  encoding_types.clear();
+  encoding_types.push_back(Filter::FILTER_TYPE_SDCH);
+  filter = Filter::Factory(encoding_types, filter_context);
+  ASSERT_EQ(NULL, filter);
+
+  // Adding both GZIP and SDCH should provide NULL filter.
+  encoding_types.clear();
+  encoding_types.push_back(Filter::FILTER_TYPE_GZIP);
+  encoding_types.push_back(Filter::FILTER_TYPE_SDCH);
+  filter = Filter::Factory(encoding_types, filter_context);
+  ASSERT_EQ(NULL, filter);
+}
+
 }  // namespace net