Per-packet options now passed through to QuicPacketWriter, instead of

Per-packet options now passed through to QuicPacketWriter, instead of
through PerConnectionPacketWriter side channels. No functional change.
Guarded by FLAGS_quic_connection_use_shared_writer (this flag is not
used in chromium code base).

This is being done mostly to avoid a few cache misses, though in
practice the performance improvement is in the noise. If nothing else,
all of the costs associated with ???PerConnectionPacketWriter are now
gone from the profile.

Merge internal change: 113068996

R=jdorfman@google.com, rch@chromium.org

[Ryan Hamilton, 2016-02-02 06:34:24]

lgtm

https://codereview.chromium.org/1662433002/diff/1/net/quic/quic_chromium_pack...
File net/quic/quic_chromium_packet_writer.cc (right):

https://codereview.chromium.org/1662433002/diff/1/net/quic/quic_chromium_pack...
net/quic/quic_chromium_packet_writer.cc:28: PerPacketOptions* options) {
nit: /*options*/ since this argument is unused.

[ramant (doing other things), 2016-02-02 06:37:33]

https://codereview.chromium.org/1662433002/diff/1/net/quic/quic_chromium_pack...
File net/quic/quic_chromium_packet_writer.cc (right):

https://codereview.chromium.org/1662433002/diff/1/net/quic/quic_chromium_pack...
net/quic/quic_chromium_packet_writer.cc:28: PerPacketOptions* options) {
On 2016/02/02 06:34:24, Ryan Hamilton wrote:
> nit: /*options*/ since this argument is unused.

Done.

https://codereview.chromium.org/1662433002/diff/1/net/tools/quic/test_tools/p...
File net/tools/quic/test_tools/packet_dropping_test_writer.h (right):

https://codereview.chromium.org/1662433002/diff/1/net/tools/quic/test_tools/p...
net/tools/quic/test_tools/packet_dropping_test_writer.h:134:
DelayedWrite(DelayedWrite&& other);
My guess, is on windows, this method won't compile. Had a similar issue in
PacketNumberQueue. Will give this a try again.

https://code.google.com/p/chromium/codesearch#chromium/src/net/quic/quic_prot...

https://codereview.chromium.org/1662433002/diff/1/net/tools/quic/test_tools/p...
net/tools/quic/test_tools/packet_dropping_test_writer.h:136: //    DelayedWrite&
operator=(DelayedWrite&& other);
jdorfman: On linux, operator= results in an error - IPAddressNumber doesn't
support move. In chromium, this method is not needed.

[ramant (doing other things), 2016-02-02 06:38:07]

On 2016/02/02 06:34:24, Ryan Hamilton wrote:
> lgtm
> 
>
https://codereview.chromium.org/1662433002/diff/1/net/quic/quic_chromium_pack...
> File net/quic/quic_chromium_packet_writer.cc (right):
> 
>
https://codereview.chromium.org/1662433002/diff/1/net/quic/quic_chromium_pack...
> net/quic/quic_chromium_packet_writer.cc:28: PerPacketOptions* options) {
> nit: /*options*/ since this argument is unused.

Wow!. You are up very late. Thanks very much for such a quick review.

[ramant (doing other things), 2016-02-02 06:43:15]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-02 06:44:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1662433002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1662433002/20001

[commit-bot: I haz the power, 2016-02-02 08:12:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-02 08:12:34]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2016-02-02 15:00:00]

lgtm