net/quic/quic_session_test.cc - Issue 1662433002: Per-packet options now passed through to QuicPacketWriter, instead of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_session_test.cc

Issue 1662433002: Per-packet options now passed through to QuicPacketWriter, instead of (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@113054959

Patch Set: Fix comments for Patch Set 1 Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_session_test.cc

diff --git a/net/quic/quic_session_test.cc b/net/quic/quic_session_test.cc

index 9dcbecb5c48098dd8653706676cc290ad4def8a3..07b1fc7b8e60298a8ea7068aa11b5b97432dd045 100644

--- a/net/quic/quic_session_test.cc

+++ b/net/quic/quic_session_test.cc

@@ -538,7 +538,7 @@ TEST_P(QuicSessionTestServer, OnCanWriteBundlesStreams) {

// should be bundled together.

MockPacketWriter* writer = static_cast<MockPacketWriter*>(

QuicConnectionPeer::GetWriter(session_.connection()));

- EXPECT_CALL(*writer, WritePacket(_, _, _, _))

+ EXPECT_CALL(*writer, WritePacket(_, _, _, _, _))

.WillOnce(Return(WriteResult(WRITE_STATUS_OK, 0)));

EXPECT_CALL(*send_algorithm, OnPacketSent(_, _, _, _, _));

session_.OnCanWrite();

@@ -683,7 +683,7 @@ TEST_P(QuicSessionTestServer, OnCanWriteLimitsNumWritesIfFlowControlBlocked) {

TEST_P(QuicSessionTestServer, SendGoAway) {

MockPacketWriter* writer = static_cast<MockPacketWriter*>(

QuicConnectionPeer::GetWriter(session_.connection()));

- EXPECT_CALL(*writer, WritePacket(_, _, _, _))

+ EXPECT_CALL(*writer, WritePacket(_, _, _, _, _))

.WillOnce(Return(WriteResult(WRITE_STATUS_OK, 0)));

EXPECT_CALL(*connection_, SendGoAway(_, _, _))

.WillOnce(Invoke(connection_, &MockConnection::ReallySendGoAway));

« no previous file with comments | « net/quic/quic_packet_writer.h ('k') | net/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »