Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1662373002: Add UI to filter fuzzes based on tags. (Closed)

Created:
4 years, 10 months ago by kjlubick
Modified:
4 years, 10 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@add-asan
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add UI to filter fuzzes based on tags. There isn't a nice way to perform dynamic sums of child elements in polymer (that I thought of, at least), so I resurrected fuzzer-collapse-function to make the code easier to reason about. This also bypasses the old "overview" which only showed the counts. That was very awkward with the filters, so I bypassed it. Look for the deletion in the next CL. BUG=skia:4438 Committed: https://skia.googlesource.com/buildbot/+/92d8a7cec8f1e9a9457eba37ded33fbf24532991

Patch Set 1 #

Patch Set 2 : Undo deletes of overview things #

Patch Set 3 : Fix links #

Total comments: 1

Patch Set 4 : Change delimiters to be like gold #

Patch Set 5 : remove conflicting status-sk elements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+837 lines, -252 lines) Patch
M fuzzer/go/frontend/data/report.go View 1 2 chunks +22 lines, -16 lines 0 comments Download
M fuzzer/go/fuzzer-fe/main.go View 1 2 3 7 chunks +21 lines, -15 lines 0 comments Download
M fuzzer/res/imp/README.md View 1 chunk +22 lines, -15 lines 0 comments Download
M fuzzer/res/imp/fuzzer-collapse-details-sk.html View 7 chunks +110 lines, -61 lines 0 comments Download
M fuzzer/res/imp/fuzzer-collapse-details-sk-demo.html View 1 chunk +4 lines, -4 lines 0 comments Download
M fuzzer/res/imp/fuzzer-collapse-file-sk.html View 1 2 5 chunks +45 lines, -19 lines 0 comments Download
A fuzzer/res/imp/fuzzer-collapse-function-sk.html View 1 chunk +149 lines, -0 lines 0 comments Download
A fuzzer/res/imp/fuzzer-collapse-function-sk-demo.html View 1 chunk +44 lines, -0 lines 0 comments Download
A fuzzer/res/imp/fuzzer-filter-sk.html View 1 2 3 1 chunk +136 lines, -0 lines 0 comments Download
A + fuzzer/res/imp/fuzzer-filter-sk-demo.html View 1 chunk +10 lines, -5 lines 0 comments Download
M fuzzer/res/imp/fuzzer-info-sk.html View 5 chunks +51 lines, -13 lines 0 comments Download
M fuzzer/res/imp/fuzzer-info-sk-demo.html View 1 chunk +29 lines, -1 line 0 comments Download
M fuzzer/res/imp/fuzzer-menu-sk.html View 1 chunk +2 lines, -0 lines 0 comments Download
M fuzzer/res/imp/fuzzer-stacktrace-sk.html View 1 chunk +0 lines, -2 lines 0 comments Download
M fuzzer/templates/details.html View 1 2 3 1 chunk +31 lines, -22 lines 0 comments Download
M fuzzer/templates/index.html View 1 chunk +29 lines, -31 lines 0 comments Download
A + res/imp/9/url-params-sk.html View 4 chunks +57 lines, -48 lines 0 comments Download
A res/imp/9/url-params-sk-demo.html View 1 chunk +58 lines, -0 lines 0 comments Download
M res/js/common.js View 1 chunk +17 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662373002/20001
4 years, 10 months ago (2016-02-04 20:04:14 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-04 20:08:45 UTC) #4
kjlubick
4 years, 10 months ago (2016-02-05 20:55:05 UTC) #6
jcgregorio
lgtm https://codereview.chromium.org/1662373002/diff/40001/fuzzer/go/fuzzer-fe/main.go File fuzzer/go/fuzzer-fe/main.go (right): https://codereview.chromium.org/1662373002/diff/40001/fuzzer/go/fuzzer-fe/main.go#newcode107 fuzzer/go/fuzzer-fe/main.go:107: // have been changed to be {[.Thing]} instead ...
4 years, 10 months ago (2016-02-05 21:14:55 UTC) #7
jcgregorio
On 2016/02/05 at 21:14:55, jcgregorio wrote: > lgtm > > https://codereview.chromium.org/1662373002/diff/40001/fuzzer/go/fuzzer-fe/main.go > File fuzzer/go/fuzzer-fe/main.go (right): ...
4 years, 10 months ago (2016-02-05 21:16:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662373002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662373002/60001
4 years, 10 months ago (2016-02-08 13:46:24 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Infra-PerCommit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/2959)
4 years, 10 months ago (2016-02-08 13:47:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662373002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662373002/80001
4 years, 10 months ago (2016-02-08 14:12:59 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 14:15:50 UTC) #18
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/buildbot/+/92d8a7cec8f1e9a9457eba37ded33fbf2453...

Powered by Google App Engine
This is Rietveld 408576698