Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1594)

Unified Diff: fuzzer/res/imp/fuzzer-collapse-file-sk.html

Issue 1662373002: Add UI to filter fuzzes based on tags. (Closed) Base URL: https://skia.googlesource.com/buildbot@add-asan
Patch Set: remove conflicting status-sk elements Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fuzzer/res/imp/fuzzer-collapse-file-sk.html
diff --git a/fuzzer/res/imp/fuzzer-collapse-file-sk.html b/fuzzer/res/imp/fuzzer-collapse-file-sk.html
index adc91fb74300ee9c6c3d957688f2d416837a88ae..ad885ef8cab45640298e6987b98d050d7afa8dfa 100644
--- a/fuzzer/res/imp/fuzzer-collapse-file-sk.html
+++ b/fuzzer/res/imp/fuzzer-collapse-file-sk.html
@@ -23,6 +23,11 @@
byFunction: Array of FunctionDetail objects. See fuzzer-collapse-function-sk.html for schema.
expand: String, which should be "true" if the element and any children should start expanded.
+ exclude: Array of String, all fuzzes that have one or more of these strings as a flag will not
+ be shown. This array must be sorted lexographically.
+ include: Array of String, all fuzzes must have one or more of these strings as a flag to be
+ shown. This array must be sorted lexographically.
+
Methods:
setFile(file) - Programmatically set the FileDetails object.
toggleLineNumbers() - Programmtically expand/collapse the function details.
@@ -33,7 +38,7 @@
<link rel="import" href="/res/common/imp/9/details-summary.html">
<link rel="import" href="/res/imp/bower_components/iron-collapse/iron-collapse.html">
<link rel="import" href="/res/imp/bower_components/iron-icons/iron-icons.html">
-<link rel="import" href="fuzzer-collapse-details-sk.html" />
+<link rel="import" href="fuzzer-collapse-function-sk.html" />
<dom-module id="fuzzer-collapse-file-sk">
<template>
<style>
@@ -70,20 +75,16 @@
-- {{file.count}} crash-causing fuzzes
</h3>
</summary-sk>
- <template is="dom-repeat" items="{{file.byFunction}}" as="func">
- <details-sk class="func" open="[[expand]]">
- <summary-sk>
- <span>
- <a href$="{{_getDetailsLink(category, file, func)}}">Function {{func.functionName}}</a>
- -- {{func.count}} crash-causing fuzzes
- </span>
- </summary-sk>
- <ul>
- <template is="dom-repeat" items="{{func.byLineNumber}}" as="lineNumber">
- <fuzzer-collapse-details-sk details="{{lineNumber}}" details-base="{{_getDetailsLink(category, file, func)}}" expand="{{_expandFirst(index)}}"></fuzzer-collapse-details-sk>
- </template>
- </ul>
- </details-sk>
+ <template is="dom-repeat" items="{{file.byFunction}}" as="func" sort="_byCount" observe="count">
+ <fuzzer-collapse-function-sk
+ class="func-group"
+ expand="[[expand]]"
+ func="{{func}}"
+ exclude="[[exclude]]"
+ include="[[include]]"
+ details-base="{{_getDetailsLink(category, file)}}"
+ on-dom-change="_recount"
+ ></fuzzer-collapse-function-sk>
</template>
</details-sk>
</template>
@@ -108,16 +109,37 @@
type: Boolean,
value: false,
},
+ exclude: {
+ type: Array,
+ value: function() {
+ return [];
+ },
+ },
+ include: {
+ type: Array,
+ value: function() {
+ return [];
+ },
+ },
+ },
+
+ _recount: function() {
+ this.debounce("recount-file", function(){
+ this.flushDebouncer("recount-function");
+ var funcs = $$(".func-group", this.$.file);
+ var sum = 0;
+ funcs.forEach(function(a){
+ sum += a.numReports;
+ });
+ this.set("file.count", sum);
+ }.bind(this), 10);
+
},
setFile: function(file) {
this.file = file;
},
- _expandFirst: function(index) {
- return index === 0;
- },
-
_getDetailsLink: function(category, file, func) {
if (!file) {
return "#";
@@ -128,6 +150,10 @@
}
return base;
},
+ _byCount: function(a, b) {
+ // Higher counts come first
+ return b.count - a.count;
+ }
});
</script>
</dom-module>
« no previous file with comments | « fuzzer/res/imp/fuzzer-collapse-details-sk-demo.html ('k') | fuzzer/res/imp/fuzzer-collapse-function-sk.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698