Remove use_system_libsrtp build knob.

Remove use_system_libsrtp build knob.

As of https://crbug.com/328475, libsrtp in Chromium is now built against
BoringSSL's crypto primitives rather than using libsrtp's crypto
implementation. Any library that is expected to build against a bundled
library (there is no such thing as system BoringSSL, and Chromium does
not support any BoringSSL version skew) fundamentally cannot be unbundled.
In this case, the problem manifested itself as a failure to run things
inside the sandbox.

We don't support use_system_* options anyway, but as use_system_libsrtp
no longer works and won't ever work again, remove it.

BUG=501318
R=jiayl@chromium.org, phajdan.jr@chromium.org

Committed: https://chromium.googlesource.com/chromium/deps/libsrtp/+/8eecac0feef4c65e2debb42718a10eab91551f35

[davidben, 2016-02-04 19:32:24]

Description was changed from

==========
Remove use_system_libsrtp build knob.

libsrtp in Chromium is now built against BoringSSL's crypto primitives rather
than using libsrtp's implementation. Any library that is expected to build
against a bundled library (there is no such thing as system BoringSSL)
fundamentally cannot be unbundled. In this case, the problem manifested itself
as a failure to run things inside the sandbox.

We don't support use_system_* options anyway, but as use_system_libsrtp does
no longer works and is not expected to ever work again, remove it.

BUG=501318
==========

to

==========
Remove use_system_libsrtp build knob.

As of https://crbug.com/328475, libsrtp in Chromium is now built against
BoringSSL's crypto primitives rather than using libsrtp's crypto
implementation. Any library that is expected to build against a bundled
library (there is no such thing as system BoringSSL, and Chromium does
not support any BoringSSL version skew) fundamentally cannot be unbundled.
In this case, the problem manifested itself as a failure to run things
inside the sandbox.

We don't support use_system_* options anyway, but as use_system_libsrtp does
no longer works and is not expected to ever work again, remove it.

BUG=501318
==========

[davidben, 2016-02-04 19:37:11]

davidben@chromium.org changed reviewers:
+ jiayl@chromium.org, phajdan.jr@chromium.org

[davidben, 2016-02-04 19:37:11]

jiayl: Could you confirm that WebRTC doesn't need this build knob for your
OpenSSL builds? I assume not since this would only work on desktop Linux and is
generally a bad idea.

phajdan.jr: See commit description for why this build knob can't work anymore.
BoringSSL cannot under any circumstances be unbundled from Chromium, which means
that any bundled libraries that are supposed to build against it cannot be
unbundled either.

https://codereview.chromium.org/1662363002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1662363002/diff/1/BUILD.gn#newcode72
BUILD.gn:72: static_library("libsrtp") {
The diff is unfortunate. This *should* be just unindenting by two spaces,
assuming I didn't mess up.

https://codereview.chromium.org/1662363002/diff/1/libsrtp.gyp
File libsrtp.gyp (right):

https://codereview.chromium.org/1662363002/diff/1/libsrtp.gyp#newcode118
libsrtp.gyp:118: 'targets': [
Ditto about unindenting

[davidben, 2016-02-04 19:37:39]

Description was changed from

==========
Remove use_system_libsrtp build knob.

As of https://crbug.com/328475, libsrtp in Chromium is now built against
BoringSSL's crypto primitives rather than using libsrtp's crypto
implementation. Any library that is expected to build against a bundled
library (there is no such thing as system BoringSSL, and Chromium does
not support any BoringSSL version skew) fundamentally cannot be unbundled.
In this case, the problem manifested itself as a failure to run things
inside the sandbox.

We don't support use_system_* options anyway, but as use_system_libsrtp does
no longer works and is not expected to ever work again, remove it.

BUG=501318
==========

to

==========
Remove use_system_libsrtp build knob.

As of https://crbug.com/328475, libsrtp in Chromium is now built against
BoringSSL's crypto primitives rather than using libsrtp's crypto
implementation. Any library that is expected to build against a bundled
library (there is no such thing as system BoringSSL, and Chromium does
not support any BoringSSL version skew) fundamentally cannot be unbundled.
In this case, the problem manifested itself as a failure to run things
inside the sandbox.

We don't support use_system_* options anyway, but as use_system_libsrtp
no longer works and won't ever work again, remove it.

BUG=501318
==========

[jiayl, 2016-02-04 19:49:19]

jiayl@chromium.org changed reviewers:
+ juberti@chromium.org

[Paweł Hajdan Jr., 2016-02-04 21:52:08]

LGTM

[davidben, 2016-02-09 16:30:23]

jiayl: friendly ping

[jiayl, 2016-02-09 17:08:46]

lgtm

[davidben, 2016-02-09 17:12:19]

Description was changed from

==========
Remove use_system_libsrtp build knob.

As of https://crbug.com/328475, libsrtp in Chromium is now built against
BoringSSL's crypto primitives rather than using libsrtp's crypto
implementation. Any library that is expected to build against a bundled
library (there is no such thing as system BoringSSL, and Chromium does
not support any BoringSSL version skew) fundamentally cannot be unbundled.
In this case, the problem manifested itself as a failure to run things
inside the sandbox.

We don't support use_system_* options anyway, but as use_system_libsrtp
no longer works and won't ever work again, remove it.

BUG=501318
==========

to

==========
Remove use_system_libsrtp build knob.

As of https://crbug.com/328475, libsrtp in Chromium is now built against
BoringSSL's crypto primitives rather than using libsrtp's crypto
implementation. Any library that is expected to build against a bundled
library (there is no such thing as system BoringSSL, and Chromium does
not support any BoringSSL version skew) fundamentally cannot be unbundled.
In this case, the problem manifested itself as a failure to run things
inside the sandbox.

We don't support use_system_* options anyway, but as use_system_libsrtp
no longer works and won't ever work again, remove it.

BUG=501318
R=jiayl@chromium.org, phajdan.jr@chromium.org

Committed:
https://chromium.googlesource.com/chromium/deps/libsrtp/+/8eecac0feef4c65e2de...
==========

[davidben, 2016-02-09 17:12:20]

Committed patchset #1 (id:1) manually as
8eecac0feef4c65e2debb42718a10eab91551f35 (presubmit successful).