Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 166203004: Merge 252604 "Don't use automatic toolchain if GYP_MSVS_VERSION ..." (Closed)

Created:
6 years, 10 months ago by scottmg
Modified:
6 years, 10 months ago
Reviewers:
dxie, scottmg, karen
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 252604 "Don't use automatic toolchain if GYP_MSVS_VERSION ..." Makes sure that 1847 doesn't switch to VS2013 > Don't use automatic toolchain if GYP_MSVS_VERSION overridden to another version > > This accomplishes three things: > - simple switch back to 2010 temporarily, if necessary > - making sure that all bots don't switch at exactly the same time (almost all have GYP_MSVS_VERSION=2010 in their settings) > - in particular, not having Official builders switch > > Unfortunately, this will need to be merged on to the 34 branch, as it has the current "auto-use" code, so otherwise it'd switch to 2013 as soon as depot_tools starts updating the toolchain (previously, the only check was whether the toolchain exists on the local hard drive). > > R=maruel@chromium.org > BUG=323300 > > Review URL: https://codereview.chromium.org/174143003 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/gyp_chromium View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
6 years, 10 months ago (2014-02-21 20:42:40 UTC) #1
scottmg
6 years, 10 months ago (2014-02-21 20:43:12 UTC) #2
scottmg
6 years, 10 months ago (2014-02-21 20:43:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r252636.

Powered by Google App Engine
This is Rietveld 408576698