Chromium Code Reviews Chromium Code Reviews
Issue
174143003:
Don't use automatic toolchain if GYP_MSVS_VERSION overridden to another version (Closed)
DescriptionDon't use automatic toolchain if GYP_MSVS_VERSION overridden to another version
This accomplishes three things:
- simple switch back to 2010 temporarily, if necessary
- making sure that all bots don't switch at exactly the same time (almost all have GYP_MSVS_VERSION=2010 in their settings)
- in particular, not having Official builders switch
Unfortunately, this will need to be merged on to the 34 branch, as it has the current "auto-use" code, so otherwise it'd switch to 2013 as soon as depot_tools starts updating the toolchain (previously, the only check was whether the toolchain exists on the local hard drive).
R=maruel@chromium.org
BUG=323300
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252604
Patch Set 1 #Patch Set 2 : Don't use automatic toolchain if GYP_MSVS_VERSION overridden to another version #Patch Set 3 : . #Patch Set 4 : . #Patch Set 5 : reitveld #Patch Set 6 : reitveld #
Total comments: 4
Patch Set 7 : upload #Patch Set 8 : rebase #Patch Set 9 : fix rebase #Messages
Total messages: 4 (0 generated)
|
