ui/native_theme/native_theme_mac.mm - Issue 1661673004: Enables hot-tracking for overflow extension buttons in the app menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/native_theme/native_theme_mac.mm

Issue 1661673004: Enables hot-tracking for overflow extension buttons in the app menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Restores hot-tracking of extension buttons in app menu with MD (nit) Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/native_theme/native_theme_mac.mm

diff --git a/ui/native_theme/native_theme_mac.mm b/ui/native_theme/native_theme_mac.mm

index e81c60c2f4d8ede2f7780f446262546a0d964bb2..f9627ff3cb75d417b719cf57873b6a7a6b481501 100644

--- a/ui/native_theme/native_theme_mac.mm

+++ b/ui/native_theme/native_theme_mac.mm

@@ -245,7 +245,7 @@ void NativeThemeMac::PaintMenuItemBackground(

SkCanvas* canvas,

State state,

const gfx::Rect& rect,

- const MenuListExtraParams& menu_list) const {

+ const MenuItemExtraParams& menu_item) const {

SkPaint paint;

switch (state) {

case NativeTheme::kNormal:

« chrome/browser/ui/views/toolbar/toolbar_action_view.cc ('K') | « ui/native_theme/native_theme_mac.h ('k') | ui/native_theme/native_theme_win.cc » ('j') | no next file with comments »