chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc - Issue 1661673004: Enables hot-tracking for overflow extension buttons in the app menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc

Issue 1661673004: Enables hot-tracking for overflow extension buttons in the app menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Restores hot-tracking of extension buttons in app menu with MD (nit) Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/libgtk2ui/native_theme_gtk2.h ('k') | chrome/browser/ui/views/toolbar/app_menu.cc » ('j') | chrome/browser/ui/views/toolbar/toolbar_action_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc

diff --git a/chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc b/chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc

index 371e13dd271ee0adf8075c54a0d265eb9965ac5f..d9dd353a5e0dcfb8f208dd0000726f41018255b5 100644

--- a/chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc

+++ b/chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc

@@ -199,7 +199,7 @@ void NativeThemeGtk2::PaintMenuItemBackground(

SkCanvas* canvas,

State state,

const gfx::Rect& rect,

- const MenuListExtraParams& menu_list) const {

+ const MenuItemExtraParams& menu_item) const {

SkColor color;

SkPaint paint;

switch (state) {

@@ -217,6 +217,11 @@ void NativeThemeGtk2::PaintMenuItemBackground(

NOTREACHED() << "Invalid state " << state;

break;

}

+ if (menu_item.corner_radius > 0) {

+ const SkScalar radius = SkIntToScalar(menu_item.corner_radius);

+ canvas->drawRoundRect(gfx::RectToSkRect(rect), radius, radius, paint);

+ return;

+ }

canvas->drawRect(gfx::RectToSkRect(rect), paint);

}