Add VORR instruction to the integrated ARM assembler.

Add VORR instruction to the integrated ARM assembler.

Also simplify several switch statements by replacing type entries with
default.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=e295575d6c1ff80d4466aa1c72e8197a66a1ff5a

[Karl, 2016-02-02 20:55:22]

Description was changed from

==========
Add VORR instruction to the integrated ARM assembler.

Also simplify several switch statements by replacing type entries with
default.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add VORR instruction to the integrated ARM assembler.

Also simplify several switch statements by replacing type entries with
default.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2016-02-02 20:55:22]

kschimpf@google.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Karl, 2016-02-02 20:57:34]

Description was changed from

==========
Add VORR instruction to the integrated ARM assembler.

Also simplify several switch statements by replacing type entries with
default.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add VORR instruction to the integrated ARM assembler.

Also simplify several switch statements by replacing type entries with
default.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2016-02-02 20:57:36]

Committed patchset #1 (id:1) manually as
e295575d6c1ff80d4466aa1c72e8197a66a1ff5a (presubmit successful).

[Jim Stichnoth, 2016-02-02 21:47:13]

LGTM, but it looks like you already landed...

https://codereview.chromium.org/1661633002/diff/1/src/DartARM32/assembler_arm.cc
File src/DartARM32/assembler_arm.cc (right):

https://codereview.chromium.org/1661633002/diff/1/src/DartARM32/assembler_arm...
src/DartARM32/assembler_arm.cc:1310: // Moved to ARM32::AssemblerARM32::vorrq()
I expected to see something similar in the .h file.

https://codereview.chromium.org/1661633002/diff/1/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1661633002/diff/1/src/IceAssemblerARM32.cpp#n...
src/IceAssemblerARM32.cpp:2731: constexpr const char *Vorrq = "vandq";
vorrq

[Karl, 2016-02-02 21:52:45]

Fixes in CL https://codereview.chromium.org/1658423002.

https://codereview.chromium.org/1661633002/diff/1/src/DartARM32/assembler_arm.cc
File src/DartARM32/assembler_arm.cc (right):

https://codereview.chromium.org/1661633002/diff/1/src/DartARM32/assembler_arm...
src/DartARM32/assembler_arm.cc:1310: // Moved to ARM32::AssemblerARM32::vorrq()
On 2016/02/02 21:47:13, stichnot wrote:
> I expected to see something similar in the .h file.

Done.

https://codereview.chromium.org/1661633002/diff/1/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1661633002/diff/1/src/IceAssemblerARM32.cpp#n...
src/IceAssemblerARM32.cpp:2731: constexpr const char *Vorrq = "vandq";
On 2016/02/02 21:47:13, stichnot wrote:
> vorrq

Done.

[Karl, 2016-02-02 21:53:01]

Fixes in CL https://codereview.chromium.org/1658423002.