Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: src/IceAssemblerARM32.cpp

Issue 1661633002: Add VORR instruction to the integrated ARM assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceAssemblerARM32.cpp
diff --git a/src/IceAssemblerARM32.cpp b/src/IceAssemblerARM32.cpp
index 4049920d06a872183456c1a38b4e9c81e3fd4046..d996a56e41c6423bfc6e40ddcd241f41aeac27d4 100644
--- a/src/IceAssemblerARM32.cpp
+++ b/src/IceAssemblerARM32.cpp
@@ -2191,13 +2191,13 @@ void AssemblerARM32::vaddd(const Operand *OpDd, const Operand *OpDn,
void AssemblerARM32::vandq(const Operand *OpQd, const Operand *OpQm,
const Operand *OpQn) {
// VAND (register) - ARM section A8.8.287, encoding A1:
- // vand.<dt> <Qd>, <Qn>, <Qm>
+ // vand <Qd>, <Qn>, <Qm>
//
// 111100100D00nnn0ddd00001N1M1mmm0 where Dddd=OpQd, Nnnn=OpQm, and Mmmm=OpQm.
- constexpr const char *Vandqi = "vandqi";
- constexpr IValueT VandqiOpcode = B8 | B4;
+ constexpr const char *Vandq = "vandq";
+ constexpr IValueT VandqOpcode = B8 | B4;
constexpr Type ElmtTy = IceType_i8;
- emitSIMDqqq(VandqiOpcode, ElmtTy, OpQd, OpQm, OpQn, Vandqi);
+ emitSIMDqqq(VandqOpcode, ElmtTy, OpQd, OpQm, OpQn, Vandq);
}
void AssemblerARM32::vcmpd(const Operand *OpDd, const Operand *OpDm,
@@ -2722,6 +2722,18 @@ void AssemblerARM32::vmuld(const Operand *OpDd, const Operand *OpDn,
emitVFPddd(Cond, VmuldOpcode, OpDd, OpDn, OpDm, Vmuld);
}
+void AssemblerARM32::vorrq(const Operand *OpQd, const Operand *OpQm,
+ const Operand *OpQn) {
+ // VORR (register) - ARM section A8.8.360, encoding A1:
+ // vorr <Qd>, <Qn>, <Qm>
+ //
+ // 111100100D10nnn0ddd00001N1M1mmm0 where Dddd=OpQd, Nnnn=OpQm, and Mmmm=OpQm.
+ constexpr const char *Vorrq = "vandq";
Jim Stichnoth 2016/02/02 21:47:13 vorrq
Karl 2016/02/02 21:52:45 Done.
+ constexpr IValueT VorrqOpcode = B21 | B8 | B4;
+ constexpr Type ElmtTy = IceType_i8;
+ emitSIMDqqq(VorrqOpcode, ElmtTy, OpQd, OpQm, OpQn, Vorrq);
+}
+
void AssemblerARM32::vstrd(const Operand *OpDd, const Operand *OpAddress,
CondARM32::Cond Cond, const TargetInfo &TInfo) {
// VSTR - ARM section A8.8.413, encoding A1:

Powered by Google App Engine
This is Rietveld 408576698