Issue 1661573002: Add 'OriginAccessEntry::matchDomain'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1661573002: Add 'OriginAccessEntry::matchDomain'. (Closed)

Created:
4 years, 10 months ago by Mike West

Modified:
4 years, 10 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add 'OriginAccessEntry::matchDomain'. We need to ignore protocol shifts when calculating the first party for cookies, as we're otherwise breaking sites that embed secure login forms into insecure pages. It's better to weaken the check than to force those sites to put everything into plaintext. BUG=534749 R=jochen@chromium.org Review URL: https://codereview.chromium.org/1607433007 Cr-Commit-Position: refs/heads/master@{#370098} (cherry picked from commit 2cd11de2ba88e31413b0a38649f039d41206470b) Review URL: https://codereview.chromium.org/1607243002 . Cr-Commit-Position: refs/branch-heads/2623@{#19} Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907} (cherry picked from commit 4257f95488b09fcc2a3ca15f1dd09ed04ffead6c)

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -20 lines)			Patch
M	third_party/WebKit/Source/core/dom/Document.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/platform/weborigin/OriginAccessEntryTest.cpp	View	2 chunks	+21 lines, -18 lines	0 comments	Download
M	third_party/WebKit/Source/web/tests/WebDocumentTest.cpp	View	5 chunks	+17 lines, -0 lines	0 comments	Download
A	third_party/WebKit/Source/web/tests/data/first_party/nested-originSecureA.html	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Mike West

4 years, 10 months ago (2016-02-02 19:27:05 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
6807cf791ab7edf31ca6c2eae208a79060d2286e.

Expand Messages | Collapse Messages