Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1607243002: Add 'OriginAccessEntry::matchDomain'. (Closed)

Created:
4 years, 11 months ago by Mike West
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Add 'OriginAccessEntry::matchDomain'. We need to ignore protocol shifts when calculating the first party for cookies, as we're otherwise breaking sites that embed secure login forms into insecure pages. It's better to weaken the check than to force those sites to put everything into plaintext. BUG=534749 R=jochen@chromium.org Review URL: https://codereview.chromium.org/1607433007 Cr-Commit-Position: refs/heads/master@{#370098} (cherry picked from commit 2cd11de2ba88e31413b0a38649f039d41206470b) Committed: https://chromium.googlesource.com/chromium/src/+/4257f95488b09fcc2a3ca15f1dd09ed04ffead6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -20 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/weborigin/OriginAccessEntryTest.cpp View 2 chunks +21 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebDocumentTest.cpp View 5 chunks +17 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/first_party/nested-originSecureA.html View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Mike West
4 years, 11 months ago (2016-01-20 12:19:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4257f95488b09fcc2a3ca15f1dd09ed04ffead6c.

Powered by Google App Engine
This is Rietveld 408576698