[iOS] Update today_extension link flags.

[iOS] Update today_extension link flags.

Xcode 9 sets the entrypoint for today extensions with -e _NSExtensionMain, and
no longer needs to set pkstart, rpath or @executable_path.

BUG=577711
R=thakis@chromium.org

Committed: https://chromium.googlesource.com/external/gyp/+/57190fa278689da857c6dfd6b4886dbfddce98ce

[justincohen, 2016-02-02 20:52:29]

justincohen@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[justincohen, 2016-02-02 20:52:30]

PTAL!

[Nico, 2016-02-02 20:56:01]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-02-02 20:56:01]

(is it possible to update the ios app extension test in gyp to check if the
built binary was built with the right flag? then the test might tell us when a
future xcode changes flags here again)

[justincohen, 2016-02-02 21:11:27]

Description was changed from

==========
[iOS] Update today_extension link flags.

Xcode 9 sets the entrypoint for today extensions with -e _NSExtensionMain, and
no longer needs to set rpath or @executable_path.

BUG=577711
==========

to

==========
[iOS] Update today_extension link flags.

Xcode 9 sets the entrypoint for today extensions with -e _NSExtensionMain, and
no longer needs to set pkstart, rpath or @executable_path.

BUG=577711
==========

[justincohen, 2016-02-02 21:12:41]

justincohen@chromium.org changed reviewers:
+ sdefresne@chromium.org

[justincohen, 2016-02-02 21:12:41]

That's a great idea -- is there any example of us doing something similar with
gyp?  How does one do that?

[Nico, 2016-02-02 21:14:40]

On 2016/02/02 21:12:41, justincohen wrote:
> That's a great idea -- is there any example of us doing something similar with
> gyp?  How does one do that?

$ grep -R otool tools/gyp/test/

shows a few examples that are similar in spirit. How exactly you'd check for
this depends on what difference this flag makes in practice (i.e. how did you
figure out that you needed to change this? Put that command in your test)

[justincohen, 2016-02-05 20:49:09]

Removed the rpaths (since they appear to be things that should be set in the
client gyp side) and added a test.

This CL will need to land after https://codereview.chromium.org/1670883002/, and
will have minor conflicts.

PTAL!

[Nico, 2016-02-05 21:05:54]

lgtm, thanks!

[justincohen, 2016-02-05 21:23:01]

Description was changed from

==========
[iOS] Update today_extension link flags.

Xcode 9 sets the entrypoint for today extensions with -e _NSExtensionMain, and
no longer needs to set pkstart, rpath or @executable_path.

BUG=577711
==========

to

==========
[iOS] Update today_extension link flags.

Xcode 9 sets the entrypoint for today extensions with -e _NSExtensionMain, and
no longer needs to set pkstart, rpath or @executable_path.

BUG=577711
R=thakis@chromium.org

Committed:
https://chromium.googlesource.com/external/gyp/+/57190fa278689da857c6dfd6b488...
==========

[justincohen, 2016-02-05 21:23:02]

Committed patchset #5 (id:80001) manually as
57190fa278689da857c6dfd6b4886dbfddce98ce (presubmit successful).