Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: test/ios/gyptest-extension.py

Issue 1661533003: [iOS] Update today_extension link flags. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/xcode_emulation.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/ios/gyptest-extension.py
diff --git a/test/ios/gyptest-extension.py b/test/ios/gyptest-extension.py
index 5bfc62b083164bf60ab159fa99e8abcf5f4b4529..c5e76d93ff259aea1d36b3410fbd2ef7e500d0a2 100755
--- a/test/ios/gyptest-extension.py
+++ b/test/ios/gyptest-extension.py
@@ -11,13 +11,18 @@ Verifies that ios app extensions are built correctly.
import TestGyp
import TestMac
import subprocess
+import sys
-def CheckStrip(p, n_expected):
- if "ActionViewController" not in subprocess.check_output(['nm','-gU', p]):
- print "ActionViewController shouldn't get stripped out."
+def CheckStrip(p, expected):
+ if expected not in subprocess.check_output(['nm','-gU', p]):
+ print expected + " shouldn't get stripped out."
+ test.fail_test()
+
+def CheckEntrypoint(p, expected):
+ if expected not in subprocess.check_output(['nm', p]):
+ print expected + "not found."
test.fail_test()
-import sys
if sys.platform == 'darwin' and TestMac.Xcode.Version()>="0600":
test = TestGyp.TestGyp(formats=['ninja', 'xcode'])
@@ -35,6 +40,7 @@ if sys.platform == 'darwin' and TestMac.Xcode.Version()>="0600":
'ExtensionContainer.app/PlugIns/ActionExtension.appex/ActionExtension',
chdir='extension')
CheckStrip(path, "ActionViewController")
+ CheckEntrypoint(path, "_NSExtensionMain")
test.pass_test()
« no previous file with comments | « pylib/gyp/xcode_emulation.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698