Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1661463002: [wasm] Provide backoff implementations for the Fxx rounding instructions (Closed)

Created:
4 years, 10 months ago by ahaas
Modified:
4 years, 10 months ago
Reviewers:
titzer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@trunc64-external-reference
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Provide backoff implementations for the Fxx rounding instructions If the architecture does not provide rounding instructions, then C implementations of these rounding instructions are called. The C implementations from math.h are used, function pointers are registered as external references so that they can be call from the simulator. R=titzer@chromium.org BUG=575379 LOG=Y Committed: https://crrev.com/23943d0e00f2a9699eef7b1c1417c8685dba77e5 Cr-Commit-Position: refs/heads/master@{#33677}

Patch Set 1 #

Patch Set 2 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -166 lines) Patch
M src/api-experimental.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/assembler.h View 1 chunk +8 lines, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +58 lines, -3 lines 0 comments Download
M src/compiler/fast-accessor-assembler.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/wasm-compiler.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 3 chunks +82 lines, -117 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +16 lines, -2 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 4 chunks +7 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +70 lines, -10 lines 0 comments Download
M test/cctest/test-api-fast-accessor-builder.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 3 chunks +15 lines, -26 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
ahaas
4 years, 10 months ago (2016-02-02 09:30:23 UTC) #1
titzer
On 2016/02/02 09:30:23, ahaas wrote: lgtm
4 years, 10 months ago (2016-02-02 10:04:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661463002/20001
4 years, 10 months ago (2016-02-02 12:06:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10427)
4 years, 10 months ago (2016-02-02 12:16:33 UTC) #8
Yang
On 2016/02/02 12:16:33, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 10 months ago (2016-02-02 12:20:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661463002/20001
4 years, 10 months ago (2016-02-02 12:21:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-02 12:26:52 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 12:27:10 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/23943d0e00f2a9699eef7b1c1417c8685dba77e5
Cr-Commit-Position: refs/heads/master@{#33677}

Powered by Google App Engine
This is Rietveld 408576698