Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 1661423002: Solidify Entry discarding logic (NavigationHandle keeps its ID) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't initialize NavigationHandle with base url for data url Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index facb4f83ce37e8bc502dec06c298ab08c5291727..ba4190dd0c8206bd0c164e8f500b9123bda32435 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -72,7 +72,8 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
FrameTreeNode* frame_tree_node,
bool is_synchronous,
bool is_srcdoc,
- const base::TimeTicks& navigation_start);
+ const base::TimeTicks& navigation_start,
+ int pending_nav_entry_id);
~NavigationHandleImpl() override;
// NavigationHandle implementation:
@@ -120,6 +121,11 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
// as modifications will not be reflected in the network stack.
const net::HttpResponseHeaders* GetResponseHeaders();
+ // Get the unique id from the NavigationEntry associated with this
+ // NavigationHandle. Note that a synchronous, renderer-initiated navigation
+ // will not have a NavigationEntry associated with it, and this will return 0.
+ int pending_nav_entry_id() const { return pending_nav_entry_id_; }
+
void set_net_error_code(net::Error net_error_code) {
net_error_code_ = net_error_code;
}
@@ -222,7 +228,8 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
FrameTreeNode* frame_tree_node,
bool is_synchronous,
bool is_srcdoc,
- const base::TimeTicks& navigation_start);
+ const base::TimeTicks& navigation_start,
+ int pending_nav_entry_id);
NavigationThrottle::ThrottleCheckResult CheckWillStartRequest();
NavigationThrottle::ThrottleCheckResult CheckWillRedirectRequest();
@@ -269,6 +276,9 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
// The time this navigation started.
const base::TimeTicks navigation_start_;
+ // The unique id of the corresponding NavigationEntry.
+ const int pending_nav_entry_id_;
+
// This callback will be run when all throttle checks have been performed.
ThrottleChecksFinishedCallback complete_callback_;

Powered by Google App Engine
This is Rietveld 408576698