Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1661193004: Subzero. Adds symbolic references to RelocInitializer. (Closed)

Created:
4 years, 10 months ago by John
Modified:
4 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : make format #

Total comments: 5

Patch Set 3 : addresses comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -24 lines) Patch
M src/IceCfg.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/IceConverter.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceGlobalContext.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceGlobalContext.cpp View 1 3 chunks +13 lines, -13 lines 0 comments Download
M src/IceGlobalInits.h View 1 2 3 chunks +18 lines, -7 lines 0 comments Download
M src/IceGlobalInits.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/PNaClTranslator.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
John
4 years, 10 months ago (2016-02-04 15:51:02 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/1661193004/diff/20001/src/IceGlobalInits.h File src/IceGlobalInits.h (right): https://codereview.chromium.org/1661193004/diff/20001/src/IceGlobalInits.h#newcode24 src/IceGlobalInits.h:24: #include "IceOperand.h" alphabetize includes https://codereview.chromium.org/1661193004/diff/20001/src/IceGlobalInits.h#newcode350 src/IceGlobalInits.h:350: Declaration), // ...
4 years, 10 months ago (2016-02-04 16:25:26 UTC) #3
Karl
lgtm https://codereview.chromium.org/1661193004/diff/20001/src/IceGlobalInits.h File src/IceGlobalInits.h (right): https://codereview.chromium.org/1661193004/diff/20001/src/IceGlobalInits.h#newcode350 src/IceGlobalInits.h:350: Declaration), // The global declaration used in the ...
4 years, 10 months ago (2016-02-04 16:29:30 UTC) #4
John
https://codereview.chromium.org/1661193004/diff/20001/src/IceGlobalInits.h File src/IceGlobalInits.h (right): https://codereview.chromium.org/1661193004/diff/20001/src/IceGlobalInits.h#newcode24 src/IceGlobalInits.h:24: #include "IceOperand.h" On 2016/02/04 16:25:26, stichnot wrote: > alphabetize ...
4 years, 10 months ago (2016-02-04 16:37:02 UTC) #5
John
4 years, 10 months ago (2016-02-04 16:42:53 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
844211e75761ad4a87a9685f2b6b43eb2234485b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698