src/PNaClTranslator.cpp - Issue 1661193004: Subzero. Adds symbolic references to RelocInitializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/PNaClTranslator.cpp

Issue 1661193004: Subzero. Adds symbolic references to RelocInitializer. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: addresses comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/PNaClTranslator.cpp

diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp

index 13e08702ebbfb5af5e280632b28bef6152e24a17..97b8c34ce1dc4de8c1a048a81a54e26107a283e7 100644

--- a/src/PNaClTranslator.cpp

+++ b/src/PNaClTranslator.cpp

@@ -1211,9 +1211,10 @@ void GlobalsParser::ProcessRecord() {

Error(StrBuf.str());

}

+ Ice::GlobalContext *Ctx = getTranslator().getContext();

CurGlobalVar->addInitializer(

Ice::VariableDeclaration::RelocInitializer::create(

- getGlobalDeclByID(Index), Offset));

+ getGlobalDeclByID(Index), {Ice::RelocOffset::create(Ctx, Offset)}));

return;

}

default:

« no previous file with comments | « src/IceGlobalInits.cpp ('k') | no next file » | no next file with comments »