Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3565)

Unified Diff: chrome/browser/ui/website_settings/chooser_bubble_delegate.h

Issue 1661063002: Add message and Help Center link to the chooser UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merged changes from master and resolved conflicts Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/chooser_bubble_delegate.h
diff --git a/chrome/browser/ui/website_settings/chooser_bubble_delegate.h b/chrome/browser/ui/website_settings/chooser_bubble_delegate.h
index 1dd40744a8db323360e1e750e3be79bab6dbb210..28e2d962b0ea4917a8ed7908accb6658bfa799c2 100644
--- a/chrome/browser/ui/website_settings/chooser_bubble_delegate.h
+++ b/chrome/browser/ui/website_settings/chooser_bubble_delegate.h
@@ -52,6 +52,9 @@ class ChooserBubbleDelegate : public BubbleDelegate {
virtual ~Observer() {}
};
+ // Open help center URL.
+ void OpenHelpCenterUrl() const;
+
// BubbleDelegate:
std::string GetName() const override;
scoped_ptr<BubbleUi> BuildBubbleUi() override;
@@ -77,6 +80,9 @@ class ChooserBubbleDelegate : public BubbleDelegate {
// closes without the user taking an explicit action.
virtual void Close() = 0;
+ // Get help center URL.
+ virtual base::string16 GetHelpCenterUrl() const = 0;
msw 2016/02/22 20:13:11 Why doesn't this return a GURL?
juncai 2016/02/22 22:06:37 There is a follow-up patch for Mac: https://codere
Evan Stade 2016/02/22 23:15:16 That is a platform-specific implementation detail.
juncai 2016/02/23 01:34:21 Done.
+
// Only one observer may be registered at a time.
void set_observer(Observer* observer) { observer_ = observer; }
Observer* observer() const { return observer_; }

Powered by Google App Engine
This is Rietveld 408576698