Add message and Help Center link to the chooser UI

chrome/browser/ui/website_settings/chooser_bubble_delegate.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_DELEGATE_H_
 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_DELEGATE_H_
 
 #include <vector>
 
 #include "base/macros.h"
@@ skipping 34 matching lines @@
     // Called when GetOption(index) is no longer present, and all later
     // options have been moved earlier by 1 slot. Calling GetOption(index)
     // from inside a call to OnOptionRemoved will NOT see the removed string
     // since the options have already been updated.
     virtual void OnOptionRemoved(size_t index) = 0;
 
    protected:
     virtual ~Observer() {}
   };
 
+  // Open help center URL.
+  void OpenHelpCenterUrl() const;
+
   // BubbleDelegate:
   std::string GetName() const override;
   scoped_ptr<BubbleUi> BuildBubbleUi() override;
   const content::RenderFrameHost* OwningFrame() const override;
 
   // The number of options users can pick from. For example, it can be
   // the number of USB/Bluetooth device names which are listed in the
   // chooser bubble so that users can grant permission.
   virtual size_t NumOptions() const = 0;
 
   // The |index|th option string which is listed in the chooser bubble.
   virtual const base::string16& GetOption(size_t index) const = 0;
 
   // These three functions are called just before this object is destroyed:
 
   // Called when the user selects the |index|th element from the dialog.
   virtual void Select(size_t index) = 0;
 
   // Called when the user presses the 'Cancel' button in the dialog.
   virtual void Cancel() = 0;
 
   // Called when the user clicks outside the dialog or the dialog otherwise
   // closes without the user taking an explicit action.
   virtual void Close() = 0;
 
+  // Get help center URL.
+  virtual base::string16 GetHelpCenterUrl() const = 0;

[msw, 2016/02/22 20:13:11]

Why doesn't this return a GURL?

[juncai, 2016/02/22 22:06:37]

There is a follow-up patch for Mac:
https://codereview.chromium.org/1665343003/
And it uses HyperlinkTextView:
https://code.google.com/p/chromium/codesearch#chromium/src/ui/base/cocoa/cont...
which has a NSString* parameter, so I think that returns a base::string16 is
more convenient to use.

[Evan Stade, 2016/02/22 23:15:16]

That is a platform-specific implementation detail. This should return a GURL and
let mac convert if it needs to. This is logically a URL. The type should match
that.

[juncai, 2016/02/23 01:34:21]

Done.

+
   // Only one observer may be registered at a time.
   void set_observer(Observer* observer) { observer_ = observer; }
   Observer* observer() const { return observer_; }
 
  private:
   Browser* browser_;
   const content::RenderFrameHost* const owning_frame_;
   Observer* observer_ = nullptr;
 
   DISALLOW_COPY_AND_ASSIGN(ChooserBubbleDelegate);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_DELEGATE_H_