third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp - Issue 1660863002: Force all LayoutUnit construction to be explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

Issue 1660863002: Force all LayoutUnit construction to be explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix LayoutRectTest.cpp Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp b/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

index ebdd408ef4f3c87b74fe5879c58922ddd2badc71..354675fd5af8b089af80044d9469502edddcd044 100644

--- a/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

@@ -154,8 +154,8 @@ void SliderThumbElement::setPositionFromPoint(const LayoutPoint& point)

if (closest.isFinite()) {

double closestFraction = stepRange.proportionFromValue(closest).toDouble();

double closestRatio = isVertical || !isLeftToRightDirection ? 1.0 - closestFraction : closestFraction;

- LayoutUnit closestPosition = trackSize * closestRatio;

- const LayoutUnit snappingThreshold = 5;

+ LayoutUnit closestPosition(trackSize * closestRatio);

+ const LayoutUnit snappingThreshold(5);

if ((closestPosition - position).abs() <= snappingThreshold)

value = closest;

}