Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 16606: Enable Hebrew spell checker after Jeremy fixed the underlying Webkit bug.... (Closed)

Created:
11 years, 11 months ago by xji
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Enable Hebrew spell checker after Jeremy fixed the underlying Webkit bug. Related bug: http://code.google.com/p/chromium/issues/detail?id=2779 Related Webkit fix: http://trac.webkit.org/changeset/36874 Test: Steps to repro: 1) open chrome, Hebrew UI 2) make sure the spell checker is on, and is set to Hebrew 3) type some Hebrew text in a RTL box (like RTL plain text finto), and use a Hebrew word that the speller does not know. 4) type some more Without the underlying Webkit fix: the highlight marker is in a wrong location, and keeps moving while typing more words after the unrecognized one. With the underlying Webkit fix: the highlight marker is in a correct and fixed location. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/spellchecker.cc View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698