Add some more fields to cloudtail metrics to make them more useful.

Add some more fields to cloudtail metrics to make them more useful.

Rename the metrics so the new definitions don't clash with the old ones.

BUG=

Committed: https://chromium.googlesource.com/infra/infra/+/ebcef7c539f6b8bc17397c8097919927c15bd321

[dsansome, 2016-02-02 04:19:38]

dsansome@chromium.org changed reviewers:
+ vadimsh@chromium.org

[dsansome, 2016-02-02 04:19:39]

All this information gets munged into the job_name field currently, but it's
hard to extract and filter on in monitoring consoles.

[Vadim Sh., 2016-02-02 05:41:50]

lgtm

I also had "feature" request: disable tsmon is /etc/chrome-infra/ts-mon.json is
not found, instead of hard failing completely.

(e.g. try to run 'cloudtail send -text hi -debug' without
/etc/chrome-infra/ts-mon.json. It should still produce debug output, instead of
failing with "cannot open /etc/chrome-infra/ts-mon.json").

[Vadim Sh., 2016-02-02 05:46:01]

also, is tsmon for Go (client side) good enough to use for real? I wanted to
instrument some stuff in
https://chrome-internal.googlesource.com/infra/infra_internal/+/master/go/src...

[dsansome, 2016-02-03 03:16:28]

> I also had "feature" request: disable tsmon is /etc/chrome-infra/ts-mon.json
is
> not found, instead of hard failing completely.

Good idea - I'll send you another CL separately.

> also, is tsmon for Go (client side) good enough to use for real

It doesn't work too well on Windows yet (doesn't get the hostname properly) but
Linux seems OK!  You should be able to instrument some of the puppet stuff with
no problems.

[dsansome, 2016-02-03 03:16:32]

The CQ bit was checked by dsansome@chromium.org

[commit-bot: I haz the power, 2016-02-03 03:16:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1660453002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1660453002/1

[commit-bot: I haz the power, 2016-02-03 03:19:15]

Description was changed from

==========
Add some more fields to cloudtail metrics to make them more useful.

Rename the metrics so the new definitions don't clash with the old ones.

BUG=
==========

to

==========
Add some more fields to cloudtail metrics to make them more useful.

Rename the metrics so the new definitions don't clash with the old ones.

BUG=

Committed:
https://chromium.googlesource.com/infra/infra/+/ebcef7c539f6b8bc17397c8097919...
==========

[commit-bot: I haz the power, 2016-02-03 03:19:16]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/ebcef7c539f6b8bc17397c8097919...