Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: go/src/infra/tools/cloudtail/client.go

Issue 1660453002: Add some more fields to cloudtail metrics to make them more useful. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: go/src/infra/tools/cloudtail/client.go
diff --git a/go/src/infra/tools/cloudtail/client.go b/go/src/infra/tools/cloudtail/client.go
index ab91870daa0a029e63c388759d45ea02e1c389ec..dea44aab5dab708de9c000d0c731b30c849f5e41 100644
--- a/go/src/infra/tools/cloudtail/client.go
+++ b/go/src/infra/tools/cloudtail/client.go
@@ -75,8 +75,16 @@ type ClientOptions struct {
}
var (
- entriesCounter = metric.NewCounter("cloudtail/entries", field.String("severity"))
- writesCounter = metric.NewCounter("cloudtail/writes", field.String("result"))
+ entriesCounter = metric.NewCounter("cloudtail/log_entries",
+ field.String("log"),
+ field.String("resource_type"),
+ field.String("resource_id"),
+ field.String("severity"))
+ writesCounter = metric.NewCounter("cloudtail/api_writes",
+ field.String("log"),
+ field.String("resource_type"),
+ field.String("resource_id"),
+ field.String("result"))
)
// NewClient returns new object that knows how to push log entries to a single
@@ -169,13 +177,13 @@ func (c *loggingClient) PushEntries(entries []Entry) error {
TextPayload: e.TextPayload,
StructPayload: e.StructPayload,
}
- entriesCounter.Add(c.ctx, 1, metadata.Severity)
+ entriesCounter.Add(c.ctx, 1, c.opts.LogID, c.opts.ResourceType, c.opts.ResourceID, metadata.Severity)
}
if err := c.writeFunc(c.opts.ProjectID, c.opts.LogID, &req); err != nil {
- writesCounter.Add(c.ctx, 1, "failure")
+ writesCounter.Add(c.ctx, 1, c.opts.LogID, c.opts.ResourceType, c.opts.ResourceID, "failure")
return err
}
- writesCounter.Add(c.ctx, 1, "success")
+ writesCounter.Add(c.ctx, 1, c.opts.LogID, c.opts.ResourceType, c.opts.ResourceID, "success")
return nil
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698