Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1374)

Unified Diff: third_party/WebKit/public/platform/Platform.h

Issue 1660383002: Refactoring: Move some classes from content/child to platform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: kinuko's review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/Platform.h
diff --git a/third_party/WebKit/public/platform/Platform.h b/third_party/WebKit/public/platform/Platform.h
index 784aa7eb0fb74ccdaaffcba5f33e85c7d258468d..69aa023e5abb6eab27a50a32184cda67d19d8c27 100644
--- a/third_party/WebKit/public/platform/Platform.h
+++ b/third_party/WebKit/public/platform/Platform.h
@@ -134,6 +134,12 @@ public:
BLINK_PLATFORM_EXPORT static void shutdown();
BLINK_PLATFORM_EXPORT static Platform* current();
+ // Actual implementation of the virtual member function registerMemoryDumpProvider.
+ BLINK_PLATFORM_EXPORT static void registerMemoryDumpProviderImpl(blink::WebMemoryDumpProvider*, const char* name);
+
+ // Actual implementation of the virtual member function unregisterMemoryDumpProvider.
+ BLINK_PLATFORM_EXPORT static void unregisterMemoryDumpProviderImpl(blink::WebMemoryDumpProvider*);
kinuko 2016/02/10 01:33:22 We have number of methods that can be actually imp
hajimehoshi 2016/02/15 09:27:08 Done.
+
// May return null.
virtual WebCookieJar* cookieJar() { return nullptr; }
@@ -474,9 +480,6 @@ public:
virtual void addTraceLogEnabledStateObserver(TraceLogEnabledStateObserver*) {}
virtual void removeTraceLogEnabledStateObserver(TraceLogEnabledStateObserver*) {}
- // Returns a newly allocated WebProcessMemoryDump instance.
- virtual blink::WebProcessMemoryDump* createProcessMemoryDump() { return nullptr; }
-
typedef uint64_t WebMemoryAllocatorDumpGuid;
// Returns guid corresponding to the given string (the hash value) for

Powered by Google App Engine
This is Rietveld 408576698