Refactoring: Move some classes from content/child to platform

third_party/WebKit/public/platform/Platform.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 116 matching lines @@
 #ifdef WIN32
     typedef HANDLE FileHandle;
 #else
     typedef int FileHandle;
 #endif
 
     BLINK_PLATFORM_EXPORT static void initialize(Platform*);
     BLINK_PLATFORM_EXPORT static void shutdown();
     BLINK_PLATFORM_EXPORT static Platform* current();
 
+    // Actual implementation of the virtual member function registerMemoryDumpProvider.
+    BLINK_PLATFORM_EXPORT static void registerMemoryDumpProviderImpl(blink::WebMemoryDumpProvider*, const char* name);
+
+    // Actual implementation of the virtual member function unregisterMemoryDumpProvider.
+    BLINK_PLATFORM_EXPORT static void unregisterMemoryDumpProviderImpl(blink::WebMemoryDumpProvider*);

[kinuko, 2016/02/10 01:33:22]

We have number of methods that can be actually implemented in blink but need
different code for testing, I'm not sure if we want to add these impl methods
exposed here for all those methods.

Could we- or does it make sense to rather implement these as a default impl for
(un)registerMemoryDumpProvider and have empty impl in other subclasses like
TestBlinkWebUnitTestSupport when necessary?

BLINK_PLATFORM_EXPORT virtual void (un)registerMemoryDumpProvider(...);

[hajimehoshi, 2016/02/15 09:27:08]

Done.

+
     // May return null.
     virtual WebCookieJar* cookieJar() { return nullptr; }
 
     // Must return non-null.
     virtual WebClipboard* clipboard() { return nullptr; }
 
     // Must return non-null.
     virtual WebFileUtilities* fileUtilities() { return nullptr; }
 
     // Must return non-null.
@@ skipping 320 matching lines @@
     public:
         virtual ~TraceLogEnabledStateObserver() = default;
         virtual void onTraceLogEnabled() = 0;
         virtual void onTraceLogDisabled() = 0;
     };
 
     // Register or unregister a trace log state observer. Does not take ownership.
     virtual void addTraceLogEnabledStateObserver(TraceLogEnabledStateObserver*) {}
     virtual void removeTraceLogEnabledStateObserver(TraceLogEnabledStateObserver*) {}
 
-    // Returns a newly allocated WebProcessMemoryDump instance.
-    virtual blink::WebProcessMemoryDump* createProcessMemoryDump() { return nullptr; }
-
     typedef uint64_t WebMemoryAllocatorDumpGuid;
 
     // Returns guid corresponding to the given string (the hash value) for
     // creating a WebMemoryAllocatorDump.
     virtual WebMemoryAllocatorDumpGuid createWebMemoryAllocatorDumpGuid(const WebString& guidStr) { return 0; }
 
     // GPU ----------------------------------------------------------------
     //
     // May return null if GPU is not supported.
     // Returns newly allocated and initialized offscreen WebGraphicsContext3D instance.
@@ skipping 150 matching lines @@
 protected:
     BLINK_PLATFORM_EXPORT Platform();
     virtual ~Platform() { }
 
     WebThread* m_mainThread;
 };
 
 } // namespace blink
 
 #endif