chrome/browser/ui/cocoa/view_id_util_browsertest.mm - Issue 1660273003: Keep focus on Find-In-Page buttons when using the keyboard to navigate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/view_id_util_browsertest.mm

Issue 1660273003: Keep focus on Find-In-Page buttons when using the keyboard to navigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove viewIDs for findbar and add them to the exception list. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/view_id_util_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm

index bb96466f0b8f5224826f01e36d84033c8dc16efc..91de2236c889e762aecc3c950ed126347064b7d0 100644

--- a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm

+++ b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm

@@ -76,7 +76,10 @@ class ViewIDTest : public InProcessBrowserTest {

i == VIEW_ID_SCRIPT_BUBBLE ||

i == VIEW_ID_SAVE_CREDIT_CARD_BUTTON ||

i == VIEW_ID_TRANSLATE_BUTTON ||

- i == VIEW_ID_LOCATION_ICON) {

+ i == VIEW_ID_LOCATION_ICON ||

+ i == VIEW_ID_FIND_IN_PAGE_PREVIOUS_BUTTON ||

+ i == VIEW_ID_FIND_IN_PAGE_NEXT_BUTTON ||

+ i == VIEW_ID_FIND_IN_PAGE_CLOSE_BUTTON) {

continue;

}

« no previous file with comments | « AUTHORS ('k') | chrome/browser/ui/view_ids.h » ('j') | no next file with comments »