Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: chrome/browser/ui/cocoa/view_id_util_browsertest.mm

Issue 1660273003: Keep focus on Find-In-Page buttons when using the keyboard to navigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove viewIDs for findbar and add them to the exception list. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « AUTHORS ('k') | chrome/browser/ui/view_ids.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/strings/utf_string_conversions.h" 6 #include "base/strings/utf_string_conversions.h"
7 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 7 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
8 #include "chrome/browser/devtools/devtools_window_testing.h" 8 #include "chrome/browser/devtools/devtools_window_testing.h"
9 #include "chrome/browser/download/download_shelf.h" 9 #include "chrome/browser/download/download_shelf.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 for (int i = VIEW_ID_TOOLBAR; i < VIEW_ID_PREDEFINED_COUNT; ++i) { 69 for (int i = VIEW_ID_TOOLBAR; i < VIEW_ID_PREDEFINED_COUNT; ++i) {
70 // Mac implementation does not support following ids yet. 70 // Mac implementation does not support following ids yet.
71 // TODO(palmer): crbug.com/536257: Enable VIEW_ID_LOCATION_ICON. 71 // TODO(palmer): crbug.com/536257: Enable VIEW_ID_LOCATION_ICON.
72 if (i == VIEW_ID_STAR_BUTTON || 72 if (i == VIEW_ID_STAR_BUTTON ||
73 i == VIEW_ID_CONTENTS_SPLIT || 73 i == VIEW_ID_CONTENTS_SPLIT ||
74 i == VIEW_ID_BROWSER_ACTION || 74 i == VIEW_ID_BROWSER_ACTION ||
75 i == VIEW_ID_FEEDBACK_BUTTON || 75 i == VIEW_ID_FEEDBACK_BUTTON ||
76 i == VIEW_ID_SCRIPT_BUBBLE || 76 i == VIEW_ID_SCRIPT_BUBBLE ||
77 i == VIEW_ID_SAVE_CREDIT_CARD_BUTTON || 77 i == VIEW_ID_SAVE_CREDIT_CARD_BUTTON ||
78 i == VIEW_ID_TRANSLATE_BUTTON || 78 i == VIEW_ID_TRANSLATE_BUTTON ||
79 i == VIEW_ID_LOCATION_ICON) { 79 i == VIEW_ID_LOCATION_ICON ||
80 i == VIEW_ID_FIND_IN_PAGE_PREVIOUS_BUTTON ||
81 i == VIEW_ID_FIND_IN_PAGE_NEXT_BUTTON ||
82 i == VIEW_ID_FIND_IN_PAGE_CLOSE_BUTTON) {
80 continue; 83 continue;
81 } 84 }
82 85
83 CheckViewID(static_cast<ViewID>(i), true); 86 CheckViewID(static_cast<ViewID>(i), true);
84 } 87 }
85 88
86 CheckViewID(VIEW_ID_TAB, true); 89 CheckViewID(VIEW_ID_TAB, true);
87 CheckViewID(VIEW_ID_TAB_STRIP, true); 90 CheckViewID(VIEW_ID_TAB_STRIP, true);
88 CheckViewID(VIEW_ID_PREDEFINED_COUNT, false); 91 CheckViewID(VIEW_ID_PREDEFINED_COUNT, false);
89 92
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 } 127 }
125 128
126 // Open the 11th tab. 129 // Open the 11th tab.
127 browser()->OpenURL(OpenURLParams(GURL(url::kAboutBlankURL), 130 browser()->OpenURL(OpenURLParams(GURL(url::kAboutBlankURL),
128 Referrer(), 131 Referrer(),
129 NEW_BACKGROUND_TAB, 132 NEW_BACKGROUND_TAB,
130 ui::PAGE_TRANSITION_TYPED, 133 ui::PAGE_TRANSITION_TYPED,
131 false)); 134 false));
132 CheckViewID(VIEW_ID_TAB_LAST, true); 135 CheckViewID(VIEW_ID_TAB_LAST, true);
133 } 136 }
OLDNEW
« no previous file with comments | « AUTHORS ('k') | chrome/browser/ui/view_ids.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698