Remove many features when building product mode

Remove many features when building product mode

Move all JSON printing code from object.cc to object_service.cc.

Not compiled in:

- Service protocol
- Debugger
- Debugger API
- JSONStream
- ObjectIdRing
- Profiler service
- Object JSON printing

Size of dart_bootstrap before: 5670365 bytes
Size of dart_bootstrap after: 5287631 bytes

Reduction in size: 382734 bytes.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/d295b9c31182cd795c1349b9e18f5c9f9a3d9f9c

[Cutch, 2016-02-02 21:11:37]

johnmccutchan@google.com changed reviewers:
+ iposva@google.com

[Cutch, 2016-02-02 21:13:29]

Description was changed from

==========
Remove many features when building product mode
==========

to

==========
Remove many features when building product mode

Not compiled in:

- Service protocol
- Debugger
- Debugger API
- JSONStream
- ObjectIdRing
- Profiler service
==========

[Cutch, 2016-02-02 21:14:19]

Description was changed from

==========
Remove many features when building product mode

Not compiled in:

- Service protocol
- Debugger
- Debugger API
- JSONStream
- ObjectIdRing
- Profiler service
==========

to

==========
Remove many features when building product mode

Not compiled in:

- Service protocol
- Debugger
- Debugger API
- JSONStream
- ObjectIdRing
- Profiler service


------

Hacks & Patterns used:

// HACK...
#define PRODUCT 1

#ifdef PRODUCT
const bool BUILD_MODE_product = true;
#else
const bool BUILD_MODE_product = false;
#endif


if (BUILD_MODE_product) {
  return;
}

#ifndef PRODUCT
...
#endif  // !PRODUCT
==========

[Cutch, 2016-02-02 22:05:14]

Description was changed from

==========
Remove many features when building product mode

Not compiled in:

- Service protocol
- Debugger
- Debugger API
- JSONStream
- ObjectIdRing
- Profiler service


------

Hacks & Patterns used:

// HACK...
#define PRODUCT 1

#ifdef PRODUCT
const bool BUILD_MODE_product = true;
#else
const bool BUILD_MODE_product = false;
#endif


if (BUILD_MODE_product) {
  return;
}

#ifndef PRODUCT
...
#endif  // !PRODUCT
==========

to

==========
Remove many features when building product mode

Move all JSON printing code from object.cc to object_service.cc.

Not compiled in:

- Service protocol
- Debugger
- Debugger API
- JSONStream
- ObjectIdRing
- Profiler service
- Object JSON printing

------

Hacks & Patterns used:

// HACK...
#define PRODUCT 1

#ifdef PRODUCT
const bool BUILD_MODE_product = true;
#else
const bool BUILD_MODE_product = false;
#endif


if (BUILD_MODE_product) {
  return;
}

#ifndef PRODUCT
...
#endif  // !PRODUCT
==========

[Cutch, 2016-02-02 22:29:29]

PTAL

[Cutch, 2016-02-04 16:43:54]

Description was changed from

==========
Remove many features when building product mode

Move all JSON printing code from object.cc to object_service.cc.

Not compiled in:

- Service protocol
- Debugger
- Debugger API
- JSONStream
- ObjectIdRing
- Profiler service
- Object JSON printing

------

Hacks & Patterns used:

// HACK...
#define PRODUCT 1

#ifdef PRODUCT
const bool BUILD_MODE_product = true;
#else
const bool BUILD_MODE_product = false;
#endif


if (BUILD_MODE_product) {
  return;
}

#ifndef PRODUCT
...
#endif  // !PRODUCT
==========

to

==========
Remove many features when building product mode

Move all JSON printing code from object.cc to object_service.cc.

Not compiled in:

- Service protocol
- Debugger
- Debugger API
- JSONStream
- ObjectIdRing
- Profiler service
- Object JSON printing
==========

[Cutch, 2016-02-04 17:49:44]

Description was changed from

==========
Remove many features when building product mode

Move all JSON printing code from object.cc to object_service.cc.

Not compiled in:

- Service protocol
- Debugger
- Debugger API
- JSONStream
- ObjectIdRing
- Profiler service
- Object JSON printing
==========

to

==========
Remove many features when building product mode

Move all JSON printing code from object.cc to object_service.cc.

Not compiled in:

- Service protocol
- Debugger
- Debugger API
- JSONStream
- ObjectIdRing
- Profiler service
- Object JSON printing

Size of dart_bootstrap before: 5670365 bytes
Size of dart_bootstrap after: 5287631 bytes

Reduction in size: 382734 bytes.
==========

[Cutch, 2016-02-04 18:52:16]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[Cutch, 2016-02-04 18:52:16]

PTAL

[rmacnak, 2016-02-04 21:26:41]

Several crashes running

tools/test.py -mrelease --vm-options="--support_debugger=false
--support_service=false --support_coverage=false --support_timeline=false"

https://chromiumcodereview.appspot.com/1660063002/diff/40001/runtime/vm/compi...
File runtime/vm/compiler.cc (right):

https://chromiumcodereview.appspot.com/1660063002/diff/40001/runtime/vm/compi...
runtime/vm/compiler.cc:1375: isolate->debugger()->NotifyCompilation(function);
+ FLAG_support_debug  (or the flag is partially ignored in release mode)

https://chromiumcodereview.appspot.com/1660063002/diff/40001/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://chromiumcodereview.appspot.com/1660063002/diff/40001/runtime/vm/dart....
runtime/vm/dart.cc:403: #ifndef PRODUCT
+ FLAG_support_debugger

https://chromiumcodereview.appspot.com/1660063002/diff/40001/runtime/vm/dart_...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/1660063002/diff/40001/runtime/vm/dart_...
runtime/vm/dart_api_impl.cc:5544: I->debugger()->NotifyDoneLoading();
+ FLAG_support_debugger

https://chromiumcodereview.appspot.com/1660063002/diff/40001/runtime/vm/dart_...
runtime/vm/dart_api_impl.cc:5673: return Api::Success();
Should we expect the embedder to also behave a bit differently when PRODUCT is
defined? If so this probably should be an error.

https://chromiumcodereview.appspot.com/1660063002/diff/40001/runtime/vm/debug...
File runtime/vm/debugger_api_impl_test.cc (right):

https://chromiumcodereview.appspot.com/1660063002/diff/40001/runtime/vm/debug...
runtime/vm/debugger_api_impl_test.cc:2332: #endif
// !PRODUCT

https://chromiumcodereview.appspot.com/1660063002/diff/40001/runtime/vm/gc_ma...
File runtime/vm/gc_marker.cc (right):

https://chromiumcodereview.appspot.com/1660063002/diff/40001/runtime/vm/gc_ma...
runtime/vm/gc_marker.cc:565: #ifndef PRODUCT
+ FLAG_support_service

https://chromiumcodereview.appspot.com/1660063002/diff/40001/runtime/vm/isola...
File runtime/vm/isolate.cc (right):

https://chromiumcodereview.appspot.com/1660063002/diff/40001/runtime/vm/isola...
runtime/vm/isolate.cc:513: #ifdef PRODUCT
+ FLAG_support_service

https://chromiumcodereview.appspot.com/1660063002/diff/40001/runtime/vm/isola...
runtime/vm/isolate.cc:932: #ifndef PRODUCT
+ FLAG_support_debugger

https://chromiumcodereview.appspot.com/1660063002/diff/40001/runtime/vm/isola...
runtime/vm/isolate.cc:1780: #ifndef PRODUCT
+ FLAG_support_debugger

[Cutch, 2016-02-04 22:12:52]

$ ./tools/test.py --vm-options="--support_debugger=false --support_service=false
--support_coverage=false --support_timeline=false" --exclude-suite=pkg,service
Test configuration: none_vm_debug_x64
[05:10 | 100% | +13407 | -    0]

PTAL

https://codereview.chromium.org/1660063002/diff/40001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1660063002/diff/40001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:5673: return Api::Success();
On 2016/02/04 21:26:41, rmacnak wrote:
> Should we expect the embedder to also behave a bit differently when PRODUCT is
> defined? If so this probably should be an error.

I'm trying to allow 'disabled' API calls to become nops in product mode rather
than burdening the embedder with having to #ifdef their API calls.

https://codereview.chromium.org/1660063002/diff/40001/runtime/vm/gc_marker.cc
File runtime/vm/gc_marker.cc (right):

https://codereview.chromium.org/1660063002/diff/40001/runtime/vm/gc_marker.cc...
runtime/vm/gc_marker.cc:565: #ifndef PRODUCT
On 2016/02/04 21:26:41, rmacnak wrote:
> + FLAG_support_service

Done.

[rmacnak, 2016-02-05 17:45:05]

lgtm

[Cutch, 2016-02-05 17:55:55]

Description was changed from

==========
Remove many features when building product mode

Move all JSON printing code from object.cc to object_service.cc.

Not compiled in:

- Service protocol
- Debugger
- Debugger API
- JSONStream
- ObjectIdRing
- Profiler service
- Object JSON printing

Size of dart_bootstrap before: 5670365 bytes
Size of dart_bootstrap after: 5287631 bytes

Reduction in size: 382734 bytes.
==========

to

==========
Remove many features when building product mode

Move all JSON printing code from object.cc to object_service.cc.

Not compiled in:

- Service protocol
- Debugger
- Debugger API
- JSONStream
- ObjectIdRing
- Profiler service
- Object JSON printing

Size of dart_bootstrap before: 5670365 bytes
Size of dart_bootstrap after: 5287631 bytes

Reduction in size: 382734 bytes.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d295b9c31182cd795c1349b9e18f5c9f9a3d9f9c
==========

[Cutch, 2016-02-05 17:55:57]

Committed patchset #4 (id:60001) manually as
d295b9c31182cd795c1349b9e18f5c9f9a3d9f9c (presubmit successful).