Remove many features when building product mode

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 
 #include "platform/assert.h"
 #include "lib/stacktrace.h"
@@ skipping 5522 matching lines @@
   Dart_Handle state = Api::CheckAndFinalizePendingClasses(T);
   if (::Dart_IsError(state)) {
     return state;
   }
 
   // Now that the newly loaded classes are finalized, notify the debugger
   // that new code has been loaded. If there are latent breakpoints in
   // the new code, the debugger convert them to unresolved source breakpoints.
   // The code that completes the futures (invoked below) may call into the
   // newly loaded code and trigger one of these breakpoints.
+#ifndef PRODUCT
   I->debugger()->NotifyDoneLoading();

[rmacnak, 2016/02/04 21:26:41]

+ FLAG_support_debugger

+#endif  // !PRODUCT
 
   if (FLAG_enable_mirrors) {
     // Notify mirrors that MirrorSystem.libraries needs to be recomputed.
     const Library& libmirrors = Library::Handle(Z, Library::MirrorsLibrary());
     const Field& dirty_bit = Field::Handle(Z,
         libmirrors.LookupLocalField(String::Handle(String::New("dirty"))));
     ASSERT(!dirty_bit.IsNull() && dirty_bit.is_static());
     dirty_bit.SetStaticValue(Bool::True());
   }
 
@@ skipping 87 matching lines @@
 
 DART_EXPORT Dart_Port Dart_ServiceWaitForLoadPort() {
   return ServiceIsolate::WaitForLoadPort();
 }
 
 
 DART_EXPORT void Dart_RegisterIsolateServiceRequestCallback(
     const char* name,
     Dart_ServiceRequestCallback callback,
     void* user_data) {
+#ifndef PRODUCT
   Service::RegisterIsolateEmbedderCallback(name, callback, user_data);
+#endif  // !PRODUCT
 }
 
 
 DART_EXPORT void Dart_RegisterRootServiceRequestCallback(
     const char* name,
     Dart_ServiceRequestCallback callback,
     void* user_data) {
+#ifndef PRODUCT
   Service::RegisterRootEmbedderCallback(name, callback, user_data);
+#endif  // !PRODUCT
 }
 
 
 DART_EXPORT Dart_Handle Dart_SetServiceStreamCallbacks(
     Dart_ServiceStreamListenCallback listen_callback,
     Dart_ServiceStreamCancelCallback cancel_callback) {
+#ifdef PRODUCT
+  return Api::Success();

[rmacnak, 2016/02/04 21:26:41]

Should we expect the embedder to also behave a bit differently when PRODUCT is
defined? If so this probably should be an error.

[Cutch, 2016/02/04 22:12:52]

I'm trying to allow 'disabled' API calls to become nops in product mode rather
than burdening the embedder with having to #ifdef their API calls.

+#else
   if (listen_callback != NULL) {
     if (Service::stream_listen_callback() != NULL) {
       return Api::NewError(
           "%s permits only one listen callback to be registered, please "
           "remove the existing callback and then add this callback",
           CURRENT_FUNC);
     }
   } else {
     if (Service::stream_listen_callback() == NULL) {
       return Api::NewError(
@@ skipping 10 matching lines @@
     }
   } else {
     if (Service::stream_cancel_callback() == NULL) {
       return Api::NewError(
           "%s expects 'cancel_callback' to be present in the callback set.",
           CURRENT_FUNC);
     }
   }
   Service::SetEmbedderStreamCallbacks(listen_callback, cancel_callback);
   return Api::Success();
+#endif  // PRODUCT
 }
 
 
 DART_EXPORT Dart_Handle Dart_ServiceSendDataEvent(const char* stream_id,
                                                   const char* event_kind,
                                                   const uint8_t* bytes,
                                                   intptr_t bytes_length) {
+#ifdef PRODUCT
+  return Api::Success();
+#else
   DARTSCOPE(Thread::Current());
   Isolate* I = T->isolate();
   if (stream_id == NULL) {
     RETURN_NULL_ERROR(stream_id);
   }
   if (event_kind == NULL) {
     RETURN_NULL_ERROR(event_kind);
   }
   if (bytes == NULL) {
     RETURN_NULL_ERROR(bytes);
   }
   if (bytes_length < 0) {
     return Api::NewError("%s expects argument 'bytes_length' to be >= 0.",
                          CURRENT_FUNC);
   }
   Service::SendEmbedderEvent(I, stream_id, event_kind,
                              bytes, bytes_length);
   return Api::Success();
+#endif  // PRODUCT
 }
 
 
 DART_EXPORT int64_t Dart_TimelineGetMicros() {
   return OS::GetCurrentMonotonicMicros();
 }
 
 
 DART_EXPORT void Dart_TimelineSetRecordedStreams(int64_t stream_mask) {
   Isolate* isolate = Isolate::Current();
@@ skipping 137 matching lines @@
   free(output);
 
   // Finish the stream.
   FinishStreamToConsumer(consumer, user_data, "timeline");
   return true;
 }
 
 
 DART_EXPORT bool Dart_TimelineGetTrace(Dart_StreamConsumer consumer,
                                        void* user_data) {
+  if (!FLAG_support_timeline) {
+    return false;
+  }
   Isolate* isolate = Isolate::Current();
   CHECK_ISOLATE(isolate);
   if (consumer == NULL) {
     return false;
   }
   TimelineEventRecorder* timeline_recorder = Timeline::recorder();
   if (timeline_recorder == NULL) {
     // Nothing has been recorded.
     return false;
   }
   Thread* T = Thread::Current();
   StackZone zone(T);
   Timeline::ReclaimCachedBlocksFromThreads();
   JSONStream js;
   IsolateTimelineEventFilter filter(isolate->main_port());
   timeline_recorder->PrintTraceEvent(&js, &filter);
   return StreamTraceEvents(consumer, user_data, &js);
 }
 
 
 DART_EXPORT bool Dart_GlobalTimelineGetTrace(Dart_StreamConsumer consumer,
                                              void* user_data) {
+  if (!FLAG_support_timeline) {
+    return false;
+  }
   // To support various embedders, it must be possible to call this function
   // from a thread for which we have not entered an Isolate and set up a Thread
   // TLS object. Therefore, a Zone may not be available, a StackZone cannot be
   // created, and no ZoneAllocated objects can be allocated.
   if (consumer == NULL) {
     return false;
   }
   TimelineEventRecorder* timeline_recorder = Timeline::recorder();
   if (timeline_recorder == NULL) {
     // Nothing has been recorded.
@@ skipping 210 matching lines @@
   return Api::Success();
 }
 #endif  // DART_PRECOMPILER
 
 
 DART_EXPORT bool Dart_IsRunningPrecompiledCode() {
   return Dart::IsRunningPrecompiledCode();
 }
 
 }  // namespace dart