Don't miss to call ContentView.onShow when lunching content shell and test shell

Don't miss to call ContentView.onShow when lunching content shell and test shell

In the onStart callback of the activity we do not have a view yet in case
the activity lunched the first time or when it is coming back from background
and it was terminated by the os. This CL makes sure we issue onShow when
finishing initialization.

BUG=345425
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253417

[kbalazs, 2014-02-20 22:24:23]

PTAL

[Ted C, 2014-02-21 03:49:33]

https://codereview.chromium.org/165993008/diff/1/content/shell/android/shell_...
File
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java
(right):

https://codereview.chromium.org/165993008/diff/1/content/shell/android/shell_...
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java:120:
view.setContentViewClient(new ContentViewClient() {
This is getting moved in:
https://codereview.chromium.org/172043002/

With that said, I wonder if we should put onShow() in:

Shell.java#initFromNativeTabContents

Just doing:

if (getParent() != null) mContentView.onShow();

This would handle the case where showShell is called before ContentView
initialization.  And then the activity needs to know less about the state of the
active shell.

[kbalazs, 2014-02-25 16:37:18]

On 2014/02/21 03:49:33, Ted C wrote:
>
https://codereview.chromium.org/165993008/diff/1/content/shell/android/shell_...
> File
>
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java
> (right):
> 
>
https://codereview.chromium.org/165993008/diff/1/content/shell/android/shell_...
>
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java:120:
> view.setContentViewClient(new ContentViewClient() {
> This is getting moved in:
> https://codereview.chromium.org/172043002/
> 
> With that said, I wonder if we should put onShow() in:
> 
> Shell.java#initFromNativeTabContents
> 
> Just doing:
> 
> if (getParent() != null) mContentView.onShow();
> 
> This would handle the case where showShell is called before ContentView
> initialization.  And then the activity needs to know less about the state of
the
> active shell.

Done.

[Ted C, 2014-02-25 18:14:20]

lgtm

[kbalazs, 2014-02-25 22:19:35]

The CQ bit was checked by b.kelemen@samsung.com

[commit-bot: I haz the power, 2014-02-25 22:50:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/165993008/90001

[commit-bot: I haz the power, 2014-02-25 23:49:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/165993008/90001

[Paweł Hajdan Jr., 2014-02-26 05:44:42]

The CQ bit was unchecked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2014-02-26 06:00:53]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-02-26 06:16:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/165993008/90001

[commit-bot: I haz the power, 2014-02-26 12:01:22]

Change committed as 253417