content/shell/android/java/src/org/chromium/content_shell/Shell.java - Issue 165993008: Don't miss to call ContentView.onShow when lunching content shell and test shell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/java/src/org/chromium/content_shell/Shell.java

Issue 165993008: Don't miss to call ContentView.onShow when lunching content shell and test shell (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/android/java/src/org/chromium/content_shell/Shell.java

diff --git a/content/shell/android/java/src/org/chromium/content_shell/Shell.java b/content/shell/android/java/src/org/chromium/content_shell/Shell.java

index 5e21dc0ac4cdd67c9bb745b8f5ecd9d3ec439619..5ac955f721336f1ce50364ada65d9e6e2264e1de 100644

--- a/content/shell/android/java/src/org/chromium/content_shell/Shell.java

+++ b/content/shell/android/java/src/org/chromium/content_shell/Shell.java

@@ -252,6 +252,7 @@ public class Shell extends LinearLayout {

private void initFromNativeTabContents(long nativeTabContents) {

mContentView = ContentView.newInstance(getContext(), nativeTabContents, mWindow);

mContentView.setContentViewClient(mContentViewClient);

+ if (getParent() != null) mContentView.onShow();

if (mContentView.getUrl() != null) mUrlTextView.setText(mContentView.getUrl());

((FrameLayout) findViewById(R.id.contentview_holder)).addView(mContentView,

new FrameLayout.LayoutParams(

« no previous file with comments | « chrome/android/testshell/java/src/org/chromium/chrome/testshell/TabManager.java ('k') | no next file » | no next file with comments »