Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1659733003: Remove VisitorShim and move shim behavior into QuicConnection. No (Closed)

Created:
4 years, 10 months ago by ramant (doing other things)
Modified:
4 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Jeremy Dorfman
Base URL:
https://chromium.googlesource.com/chromium/src.git@112975672
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove VisitorShim and move shim behavior into QuicConnection. No functional change. Not flag protected. This is part of a broader attempt to remove spurious cache misses, pointer dereferences, and memory allocations. Merge internal change: 112982328 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -87 lines) Patch
M net/quic/quic_connection.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 6 chunks +6 lines, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_session.h View 5 chunks +3 lines, -12 lines 0 comments Download
M net/quic/quic_session.cc View 2 chunks +1 line, -75 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 3 (1 generated)
ramant (doing other things)
4 years, 10 months ago (2016-02-02 01:09:02 UTC) #1
Ryan Hamilton
4 years, 10 months ago (2016-02-02 04:23:20 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698