Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Unified Diff: net/quic/quic_connection.cc

Issue 1659733003: Remove VisitorShim and move shim behavior into QuicConnection. No (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@112975672
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection.h ('k') | net/quic/quic_connection_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index 7dda3c7b2c13f6bc192634ecf996a8511eb56da1..c96fb42e35ae04f687dda51e8b5badbab0137128 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -694,6 +694,7 @@ bool QuicConnection::OnStreamFrame(const QuicStreamFrame& frame) {
return false;
}
visitor_->OnStreamFrame(frame);
+ visitor_->PostProcessAfterData();
stats_.stream_bytes_received += frame.frame_length;
should_last_packet_instigate_acks_ = true;
return connected_;
@@ -882,6 +883,7 @@ bool QuicConnection::OnRstStreamFrame(const QuicRstStreamFrame& frame) {
<< " with error: "
<< QuicUtils::StreamErrorToString(frame.error_code);
visitor_->OnRstStream(frame);
+ visitor_->PostProcessAfterData();
should_last_packet_instigate_acks_ = true;
return connected_;
}
@@ -912,6 +914,7 @@ bool QuicConnection::OnGoAwayFrame(const QuicGoAwayFrame& frame) {
goaway_received_ = true;
visitor_->OnGoAway(frame);
+ visitor_->PostProcessAfterData();
should_last_packet_instigate_acks_ = true;
return connected_;
}
@@ -925,6 +928,7 @@ bool QuicConnection::OnWindowUpdateFrame(const QuicWindowUpdateFrame& frame) {
<< "WINDOW_UPDATE_FRAME received for stream: " << frame.stream_id
<< " with byte offset: " << frame.byte_offset;
visitor_->OnWindowUpdateFrame(frame);
+ visitor_->PostProcessAfterData();
should_last_packet_instigate_acks_ = true;
return connected_;
}
@@ -937,6 +941,7 @@ bool QuicConnection::OnBlockedFrame(const QuicBlockedFrame& frame) {
DVLOG(1) << ENDPOINT
<< "BLOCKED_FRAME received for stream: " << frame.stream_id;
visitor_->OnBlockedFrame(frame);
+ visitor_->PostProcessAfterData();
should_last_packet_instigate_acks_ = true;
return connected_;
}
@@ -1332,6 +1337,7 @@ void QuicConnection::OnCanWrite() {
{ // Limit the scope of the bundler. ACK inclusion happens elsewhere.
ScopedPacketBundler bundler(this, NO_ACK);
visitor_->OnCanWrite();
+ visitor_->PostProcessAfterData();
}
// After the visitor writes, it may have caused the socket to become write
« no previous file with comments | « net/quic/quic_connection.h ('k') | net/quic/quic_connection_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698