Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1659513002: Error reporting for SVG transform lists (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Error reporting for SVG transform lists Report too short/long argument lists to transform functions as well as trailing garbage (separators). Could still be improved wrt invalid transform functions and missing opening parenthesis. BUG=231612 Committed: https://crrev.com/c9683ab9c3bf9e6c782f6266bfab5e53bd9f7f2a Cr-Commit-Position: refs/heads/master@{#373100}

Patch Set 1 #

Patch Set 2 : type -> transformType #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -27 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +6 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/core/svg/SVGParsingError.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGParsingError.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformList.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformList.cpp View 1 6 chunks +29 lines, -26 lines 3 comments Download

Messages

Total messages: 14 (3 generated)
fs
4 years, 10 months ago (2016-02-01 21:03:32 UTC) #2
pdr.
Looks great, just one question about the test output. https://codereview.chromium.org/1659513002/diff/20001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1659513002/diff/20001/third_party/WebKit/LayoutTests/TestExpectations#newcode71 third_party/WebKit/LayoutTests/TestExpectations:71: ...
4 years, 10 months ago (2016-02-02 05:06:23 UTC) #3
fs
https://codereview.chromium.org/1659513002/diff/20001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1659513002/diff/20001/third_party/WebKit/LayoutTests/TestExpectations#newcode71 third_party/WebKit/LayoutTests/TestExpectations:71: crbug.com/231612 svg/custom/invalid-transforms.svg [ NeedsRebaseline ] On 2016/02/02 at 05:06:23, ...
4 years, 10 months ago (2016-02-02 09:30:35 UTC) #4
fs
https://codereview.chromium.org/1659513002/diff/20001/third_party/WebKit/Source/core/svg/SVGTransformList.cpp File third_party/WebKit/Source/core/svg/SVGTransformList.cpp (right): https://codereview.chromium.org/1659513002/diff/20001/third_party/WebKit/Source/core/svg/SVGTransformList.cpp#newcode125 third_party/WebKit/Source/core/svg/SVGTransformList.cpp:125: const size_t maxPossibleParams = required + optional; On 2016/02/02 ...
4 years, 10 months ago (2016-02-02 10:25:55 UTC) #5
f(malita)
lgtm
4 years, 10 months ago (2016-02-02 13:49:04 UTC) #6
pdr.
On 2016/02/02 at 09:30:35, fs wrote: > https://codereview.chromium.org/1659513002/diff/20001/third_party/WebKit/LayoutTests/TestExpectations > File third_party/WebKit/LayoutTests/TestExpectations (right): > > https://codereview.chromium.org/1659513002/diff/20001/third_party/WebKit/LayoutTests/TestExpectations#newcode71 ...
4 years, 10 months ago (2016-02-02 19:59:13 UTC) #7
fs
On 2016/02/02 at 19:59:13, pdr wrote: > On 2016/02/02 at 09:30:35, fs wrote: > > ...
4 years, 10 months ago (2016-02-02 20:22:20 UTC) #8
fs
On 2016/02/02 at 20:22:20, fs wrote: > On 2016/02/02 at 19:59:13, pdr wrote: > > ...
4 years, 10 months ago (2016-02-02 20:25:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659513002/20001
4 years, 10 months ago (2016-02-02 21:12:39 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-03 00:31:28 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 00:32:15 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c9683ab9c3bf9e6c782f6266bfab5e53bd9f7f2a
Cr-Commit-Position: refs/heads/master@{#373100}

Powered by Google App Engine
This is Rietveld 408576698