Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1655153002: Rename local limit variable in SVG transform argument parsing (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
Reviewers:
pdr.
CC:
blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename local limit variable in SVG transform argument parsing Rename maxPossibleParams to requiredWithOptional to more precisely describe what it is. BUG=231612 Committed: https://crrev.com/4b7b7876805e6a8339ee82f743306c310a88fc1b Cr-Commit-Position: refs/heads/master@{#373217}

Patch Set 1 #

Patch Set 2 : DeMorganize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/svg/SVGTransformList.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
fs
4 years, 10 months ago (2016-02-02 11:19:50 UTC) #2
pdr.
On 2016/02/02 at 11:19:50, fs wrote: > LGTM with or without the suggestion below. The ...
4 years, 10 months ago (2016-02-02 21:17:44 UTC) #3
fs
On 2016/02/02 at 21:17:44, pdr wrote: > On 2016/02/02 at 11:19:50, fs wrote: > > ...
4 years, 10 months ago (2016-02-02 22:06:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655153002/20001
4 years, 10 months ago (2016-02-03 10:33:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-03 11:37:00 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 11:37:59 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b7b7876805e6a8339ee82f743306c310a88fc1b
Cr-Commit-Position: refs/heads/master@{#373217}

Powered by Google App Engine
This is Rietveld 408576698