[Autofill] Remove warning for CC autofill on secure pages with mixed passive content

[Autofill] Remove warning for CC autofill on secure pages with mixed passive content

Test page: https://420fb7a0cffed907f3562bad84d357ad43f54dbd.googledrive.com/host/0B3xzZ-vFr2LRWVFBaWl2V0M4NFk

BUG=574839
TEST=manual

Committed: https://crrev.com/af4d5da88d32e36044079a49f1af46e7d28fff70
Cr-Commit-Position: refs/heads/master@{#372784}

[Mathieu, 2016-02-01 16:00:59]

Description was changed from

==========
[Autofill] Remove warning for CC autofill on secure pages with mixed passive
content

Test page:
https://420fb7a0cffed907f3562bad84d357ad43f54dbd.googledrive.com/host/0B3xzZ-...

BUG=574839
TEST=manual
==========

to

==========
[Autofill] Remove warning for CC autofill on secure pages with mixed passive
content

Test page:
https://420fb7a0cffed907f3562bad84d357ad43f54dbd.googledrive.com/host/0B3xzZ-...

BUG=574839
TEST=manual
==========

[Mathieu, 2016-02-01 16:00:59]

mathp@chromium.org changed reviewers:
+ palmer@chromium.org

[Mathieu, 2016-02-01 16:01:35]

Hi palmer@, can you have a look? Then I'll forward to the OWNERS.

Thanks!

[palmer, 2016-02-01 20:28:06]

lgtm

[Mathieu, 2016-02-01 20:31:55]

mathp@chromium.org changed reviewers:
+ estade@chromium.org, mnaganov@chromium.org

[Mathieu, 2016-02-01 20:31:55]

mnaganov@chromium.org: Please review changes in 
android_webview

estade@chromium.org: Please review changes in 
autofill

Thanks!

[mnaganov (inactive), 2016-02-01 20:35:09]

lgtm

[Evan Stade, 2016-02-01 20:40:36]

lgtm

https://codereview.chromium.org/1659463003/diff/1/chrome/browser/ui/autofill/...
File chrome/browser/ui/autofill/chrome_autofill_client.cc (right):

https://codereview.chromium.org/1659463003/diff/1/chrome/browser/ui/autofill/...
chrome/browser/ui/autofill/chrome_autofill_client.cc:390:
content::SSLStatus::DISPLAYED_INSECURE_CONTENT);
nit: perhaps

!(ssl_status.content_status & content::SSLStatus::RAN_INSECURE_CONTENT)

instead of these two equality checks? equality checks seem weird when dealing
with a bitmask.

[Mathieu, 2016-02-01 20:49:30]

Patchset #2 (id:20001) has been deleted

[Mathieu, 2016-02-01 20:49:56]

submitting

https://codereview.chromium.org/1659463003/diff/1/chrome/browser/ui/autofill/...
File chrome/browser/ui/autofill/chrome_autofill_client.cc (right):

https://codereview.chromium.org/1659463003/diff/1/chrome/browser/ui/autofill/...
chrome/browser/ui/autofill/chrome_autofill_client.cc:390:
content::SSLStatus::DISPLAYED_INSECURE_CONTENT);
On 2016/02/01 20:40:36, Evan Stade wrote:
> nit: perhaps
> 
> !(ssl_status.content_status & content::SSLStatus::RAN_INSECURE_CONTENT)
> 
> instead of these two equality checks? equality checks seem weird when dealing
> with a bitmask.

Done.

[Mathieu, 2016-02-01 20:49:59]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2016-02-01 20:50:00]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org,
mnaganov@chromium.org, estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1659463003/#ps40001
(title: "accepted estade's suggestion")

[commit-bot: I haz the power, 2016-02-01 20:52:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1659463003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1659463003/40001

[commit-bot: I haz the power, 2016-02-01 21:05:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-01 21:05:58]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mathieu, 2016-02-01 21:47:35]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2016-02-01 21:48:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1659463003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1659463003/40001

[commit-bot: I haz the power, 2016-02-01 22:14:55]

Description was changed from

==========
[Autofill] Remove warning for CC autofill on secure pages with mixed passive
content

Test page:
https://420fb7a0cffed907f3562bad84d357ad43f54dbd.googledrive.com/host/0B3xzZ-...

BUG=574839
TEST=manual
==========

to

==========
[Autofill] Remove warning for CC autofill on secure pages with mixed passive
content

Test page:
https://420fb7a0cffed907f3562bad84d357ad43f54dbd.googledrive.com/host/0B3xzZ-...

BUG=574839
TEST=manual
==========

[commit-bot: I haz the power, 2016-02-01 22:14:56]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-02-01 22:15:59]

Description was changed from

==========
[Autofill] Remove warning for CC autofill on secure pages with mixed passive
content

Test page:
https://420fb7a0cffed907f3562bad84d357ad43f54dbd.googledrive.com/host/0B3xzZ-...

BUG=574839
TEST=manual
==========

to

==========
[Autofill] Remove warning for CC autofill on secure pages with mixed passive
content

Test page:
https://420fb7a0cffed907f3562bad84d357ad43f54dbd.googledrive.com/host/0B3xzZ-...

BUG=574839
TEST=manual

Committed: https://crrev.com/af4d5da88d32e36044079a49f1af46e7d28fff70
Cr-Commit-Position: refs/heads/master@{#372784}
==========

[commit-bot: I haz the power, 2016-02-01 22:16:00]

Patchset 2 (id:??) landed as
https://crrev.com/af4d5da88d32e36044079a49f1af46e7d28fff70
Cr-Commit-Position: refs/heads/master@{#372784}