Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: chrome/browser/ui/autofill/chrome_autofill_client.cc

Issue 1659463003: [Autofill] Remove warning for CC autofill on secure pages with mixed passive content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/autofill/chrome_autofill_client.h" 5 #include "chrome/browser/ui/autofill/chrome_autofill_client.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 366 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 bool ChromeAutofillClient::IsContextSecure(const GURL& form_origin) { 377 bool ChromeAutofillClient::IsContextSecure(const GURL& form_origin) {
378 content::SSLStatus ssl_status; 378 content::SSLStatus ssl_status;
379 content::NavigationEntry* navigation_entry = 379 content::NavigationEntry* navigation_entry =
380 web_contents()->GetController().GetLastCommittedEntry(); 380 web_contents()->GetController().GetLastCommittedEntry();
381 if (!navigation_entry) 381 if (!navigation_entry)
382 return false; 382 return false;
383 383
384 ssl_status = navigation_entry->GetSSL(); 384 ssl_status = navigation_entry->GetSSL();
385 // Note: If changing the implementation below, also change 385 // Note: If changing the implementation below, also change
386 // AwAutofillClient::IsContextSecure. See crbug.com/505388 386 // AwAutofillClient::IsContextSecure. See crbug.com/505388
387 return ssl_status.security_style == 387 return ssl_status.security_style == content::SECURITY_STYLE_AUTHENTICATED &&
388 content::SECURITY_STYLE_AUTHENTICATED && 388 (ssl_status.content_status == content::SSLStatus::NORMAL_CONTENT ||
389 ssl_status.content_status == content::SSLStatus::NORMAL_CONTENT; 389 ssl_status.content_status ==
390 content::SSLStatus::DISPLAYED_INSECURE_CONTENT);
Evan Stade 2016/02/01 20:40:36 nit: perhaps !(ssl_status.content_status & conten
Mathieu 2016/02/01 20:49:56 Done.
390 } 391 }
391 392
392 } // namespace autofill 393 } // namespace autofill
OLDNEW
« no previous file with comments | « android_webview/native/aw_autofill_client.cc ('k') | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698