Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1659413003:
Simplify adb_gdb to accept only --output-directory / CHROMIUM_OUTPUT_DIR (Closed)
|
Created:
4 years, 10 months ago by agrieve Modified:
4 years, 10 months ago CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@adb_gdb-explicit Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSimplify adb_gdb to accept only --output-directory / CHROMIUM_OUTPUT_DIR
No longer respects setting CHROMIUM_OUT_DIR / --out-dir plus BUILDTYPE /
--release / --debug.
BUG=573345
Committed: https://crrev.com/2ac20d33d17df33a01fffb37bb657219918dfe54
Cr-Commit-Position: refs/heads/master@{#375230}
Patch Set 1 #
Total comments: 1
Patch Set 2 : rebase #Messages
Total messages: 22 (11 generated)
Description was changed from ========== Simplify adb_gdb to accept only --output-directory / CHROMIUM_OUTPUT_DIR No longer respects setting CHROMIUM_OUT_DIR / --out-dir plus BUILDTYPE / --release / --debug. BUG=573345 ========== to ========== Simplify adb_gdb to accept only --output-directory / CHROMIUM_OUTPUT_DIR No longer respects setting CHROMIUM_OUT_DIR / --out-dir plus BUILDTYPE / --release / --debug. BUG=573345 ==========
agrieve@chromium.org changed reviewers: + pasko@chromium.org
On 2016/02/03 20:02:06, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:pasko@chromium.org ptal
lgtm given that the [1] lands first.
thank you
[1] Create wrapper scripts that set --output-directory
https://codereview.chromium.org/1663103004
watk@chromium.org changed reviewers: + watk@chromium.org
Drive by :) https://codereview.chromium.org/1659413003/diff/1/build/android/adb_gdb File build/android/adb_gdb (right): https://codereview.chromium.org/1659413003/diff/1/build/android/adb_gdb#newco... build/android/adb_gdb:343: if [[ -z "$CHROMIUM_OUTPUT_DIR" ]]; then Could you change this to require either --symbol-dir or CHROMIUM_OUTPUT_DIR? I've been setting --symbol-dir because I don't want any of the magic, but with the change before this one, you need --output-directory as well as --symbol-dir even though --output-directory is redundant.
On 2016/02/09 01:04:06, watk wrote: > Drive by :) > > https://codereview.chromium.org/1659413003/diff/1/build/android/adb_gdb > File build/android/adb_gdb (right): > > https://codereview.chromium.org/1659413003/diff/1/build/android/adb_gdb#newco... > build/android/adb_gdb:343: if [[ -z "$CHROMIUM_OUTPUT_DIR" ]]; then > Could you change this to require either --symbol-dir or CHROMIUM_OUTPUT_DIR? > I've been setting --symbol-dir because I don't want any of the magic, but with > the change before this one, you need --output-directory as well as --symbol-dir > even though --output-directory is redundant. Just saw that you've got a CL to wrap adb_gdb. It won't matter once that goes in, so feel free to ignore this.
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659413003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659413003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...) android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by agrieve@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org Link to the patchset: https://codereview.chromium.org/1659413003/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659413003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659413003/20001
Message was sent while issue was closed.
Description was changed from ========== Simplify adb_gdb to accept only --output-directory / CHROMIUM_OUTPUT_DIR No longer respects setting CHROMIUM_OUT_DIR / --out-dir plus BUILDTYPE / --release / --debug. BUG=573345 ========== to ========== Simplify adb_gdb to accept only --output-directory / CHROMIUM_OUTPUT_DIR No longer respects setting CHROMIUM_OUT_DIR / --out-dir plus BUILDTYPE / --release / --debug. BUG=573345 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Simplify adb_gdb to accept only --output-directory / CHROMIUM_OUTPUT_DIR No longer respects setting CHROMIUM_OUT_DIR / --out-dir plus BUILDTYPE / --release / --debug. BUG=573345 ========== to ========== Simplify adb_gdb to accept only --output-directory / CHROMIUM_OUTPUT_DIR No longer respects setting CHROMIUM_OUT_DIR / --out-dir plus BUILDTYPE / --release / --debug. BUG=573345 Committed: https://crrev.com/2ac20d33d17df33a01fffb37bb657219918dfe54 Cr-Commit-Position: refs/heads/master@{#375230} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2ac20d33d17df33a01fffb37bb657219918dfe54 Cr-Commit-Position: refs/heads/master@{#375230} |
