Create wrapper scripts that set --output-directory

Create wrapper scripts that set --output-directory

For:
- build/android/adb_gdb*
- build/android/asan_symbolize.py
- build/android/tombstones.py
- third_party/android_platform/development/scripts/stack
- tools/perf/run_benchmark

BUG=573345
Committed: https://crrev.com/b8d204bc1b7018d3f32f0dda59d4b41655e67349
Cr-Commit-Position: refs/heads/master@{#374964}

[agrieve, 2016-02-03 19:42:34]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org, rmcilroy@chromium.org

[agrieve, 2016-02-03 19:42:34]

Wrapper scripts.

[jbudorick, 2016-02-03 19:46:28]

https://codereview.chromium.org/1663103004/diff/1/build/android/gyp/create_to...
File build/android/gyp/create_tool_script.py (right):

https://codereview.chromium.org/1663103004/diff/1/build/android/gyp/create_to...
build/android/gyp/create_tool_script.py:1: #!/usr/bin/env python
It'd be nice if this could share logic with the existing test runner script
generation logic over in
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/gyp/...

https://codereview.chromium.org/1663103004/diff/1/build/android/gyp/create_to...
build/android/gyp/create_tool_script.py:15: # The java command must be executed
in the current directory because there may
...? I'm not sure I follow the requirements implied by this comment.

[agrieve, 2016-02-04 19:27:00]

Renamed the script to "create_tool_wrapper"

https://codereview.chromium.org/1663103004/diff/1/build/android/gyp/create_to...
File build/android/gyp/create_tool_script.py (right):

https://codereview.chromium.org/1663103004/diff/1/build/android/gyp/create_to...
build/android/gyp/create_tool_script.py:1: #!/usr/bin/env python
On 2016/02/03 19:46:27, jbudorick wrote:
> It'd be nice if this could share logic with the existing test runner script
> generation logic over in
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/gyp/...

Just spent some time attempting this. Looked at:
- create_tool_script.py
- create_test_runner_script.py
- create_java_binary_wrapper.py
- create_install_script.py

Everything I tried just made the scripts more complicated than it's worth I
think.

https://codereview.chromium.org/1663103004/diff/1/build/android/gyp/create_to...
build/android/gyp/create_tool_script.py:15: # The java command must be executed
in the current directory because there may
On 2016/02/03 19:46:27, jbudorick wrote:
> ...? I'm not sure I follow the requirements implied by this comment.

Whoops, left over from create_java_binary_script.py. gone.

[agrieve, 2016-02-04 19:28:25]

agrieve@chromium.org changed reviewers:
+ yfriedman@chromium.org

[agrieve, 2016-02-04 19:28:25]

🐱

[agrieve, 2016-02-08 15:11:54]

On 2016/02/04 19:28:25, agrieve wrote:
> 🐱
bump

[jbudorick, 2016-02-08 16:14:18]

lgtm w/ location question

https://codereview.chromium.org/1663103004/diff/1/build/android/gyp/create_to...
File build/android/gyp/create_tool_script.py (right):

https://codereview.chromium.org/1663103004/diff/1/build/android/gyp/create_to...
build/android/gyp/create_tool_script.py:1: #!/usr/bin/env python
On 2016/02/04 19:27:00, agrieve wrote:
> On 2016/02/03 19:46:27, jbudorick wrote:
> > It'd be nice if this could share logic with the existing test runner script
> > generation logic over in
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/gyp/...
> 
> Just spent some time attempting this. Looked at:
> - create_tool_script.py
> - create_test_runner_script.py
> - create_java_binary_wrapper.py
> - create_install_script.py
> 
> Everything I tried just made the scripts more complicated than it's worth I
> think. 

:(

ok

https://codereview.chromium.org/1663103004/diff/20001/tools/android/wrapper_s...
File tools/android/wrapper_script.gni (right):

https://codereview.chromium.org/1663103004/diff/20001/tools/android/wrapper_s...
tools/android/wrapper_script.gni:7: template("wrapper_script") {
er why is this in tools/android/ and not in build/config/android/rules.gni?

[watk, 2016-02-09 01:06:59]

watk@chromium.org changed reviewers:
+ watk@chromium.org

[watk, 2016-02-09 01:06:59]

Just noticed an out of date comment

https://codereview.chromium.org/1663103004/diff/20001/build/android/gyp/creat...
File build/android/gyp/create_tool_wrapper.py (right):

https://codereview.chromium.org/1663103004/diff/20001/build/android/gyp/creat...
build/android/gyp/create_tool_wrapper.py:16: # This file was generated by
//build/android/gyp/create_tool_script.py
Name is out of date.

[rmcilroy, 2016-02-09 21:44:02]

lgtm

https://codereview.chromium.org/1663103004/diff/20001/tools/android/wrapper_s...
File tools/android/wrapper_script.gni (right):

https://codereview.chromium.org/1663103004/diff/20001/tools/android/wrapper_s...
tools/android/wrapper_script.gni:7: template("wrapper_script") {
On 2016/02/08 16:14:18, jbudorick wrote:
> er why is this in tools/android/ and not in build/config/android/rules.gni?

+1

[agrieve, 2016-02-10 04:02:05]

Moved it right into rules.gni (makes sense).

Also added a wrapper for tools/perf/run_benchmark

https://codereview.chromium.org/1663103004/diff/20001/tools/android/wrapper_s...
File tools/android/wrapper_script.gni (right):

https://codereview.chromium.org/1663103004/diff/20001/tools/android/wrapper_s...
tools/android/wrapper_script.gni:7: template("wrapper_script") {
On 2016/02/08 16:14:18, jbudorick wrote:
> er why is this in tools/android/ and not in build/config/android/rules.gni?

Done.

[agrieve, 2016-02-10 04:02:20]

agrieve@chromium.org changed reviewers:
+ nednguyen@google.com

[agrieve, 2016-02-10 04:02:21]

nednguyen@google.com: Please review changes in tools/perf

[agrieve, 2016-02-10 04:03:52]

Description was changed from

==========
Create wrapper scripts that set --output-directory

For: adb_gdb*, asan_symbolize.py, stack, tombstones.py

BUG=573345
==========

to

==========
Create wrapper scripts that set --output-directory

For:
- build/android/adb_gdb*
- build/android/asan_symbolize.py
- build/android/tombstones.py
- third_party/android_platform/development/scripts/stack
- tools/perf/run_benchmark

BUG=573345
==========

[nednguyen, 2016-02-10 04:09:24]

lgtm

[Yaron, 2016-02-11 18:36:46]

lgtm

https://codereview.chromium.org/1663103004/diff/40001/build/android/BUILD.gn
File build/android/BUILD.gn (right):

https://codereview.chromium.org/1663103004/diff/40001/build/android/BUILD.gn#...
build/android/BUILD.gn:102: "adb_gdb",
seems strange to wrap this particular script.. it's just used by the other
scripts below.

[agrieve, 2016-02-11 18:39:47]

Also added a TODO() about generating adb_gdb commands for android_apk()s.

https://codereview.chromium.org/1663103004/diff/40001/build/android/BUILD.gn
File build/android/BUILD.gn (right):

https://codereview.chromium.org/1663103004/diff/40001/build/android/BUILD.gn#...
build/android/BUILD.gn:102: "adb_gdb",
On 2016/02/11 18:36:46, Yaron wrote:
> seems strange to wrap this particular script.. it's just used by the other
> scripts below.

Done.

[agrieve, 2016-02-11 18:40:01]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-02-11 18:40:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org, rmcilroy@chromium.org, nednguyen@google.com,
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1663103004/#ps60001
(title: "todo + adb_gdb")

[commit-bot: I haz the power, 2016-02-11 18:41:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1663103004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1663103004/60001

[commit-bot: I haz the power, 2016-02-11 20:15:55]

Description was changed from

==========
Create wrapper scripts that set --output-directory

For:
- build/android/adb_gdb*
- build/android/asan_symbolize.py
- build/android/tombstones.py
- third_party/android_platform/development/scripts/stack
- tools/perf/run_benchmark

BUG=573345
==========

to

==========
Create wrapper scripts that set --output-directory

For:
- build/android/adb_gdb*
- build/android/asan_symbolize.py
- build/android/tombstones.py
- third_party/android_platform/development/scripts/stack
- tools/perf/run_benchmark

BUG=573345
==========

[commit-bot: I haz the power, 2016-02-11 20:15:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-16 22:37:23]

Description was changed from

==========
Create wrapper scripts that set --output-directory

For:
- build/android/adb_gdb*
- build/android/asan_symbolize.py
- build/android/tombstones.py
- third_party/android_platform/development/scripts/stack
- tools/perf/run_benchmark

BUG=573345
==========

to

==========
Create wrapper scripts that set --output-directory

For:
- build/android/adb_gdb*
- build/android/asan_symbolize.py
- build/android/tombstones.py
- third_party/android_platform/development/scripts/stack
- tools/perf/run_benchmark

BUG=573345

Committed: https://crrev.com/b8d204bc1b7018d3f32f0dda59d4b41655e67349
Cr-Commit-Position: refs/heads/master@{#374964}
==========

[commit-bot: I haz the power, 2016-02-16 22:37:24]

Patchset 4 (id:??) landed as
https://crrev.com/b8d204bc1b7018d3f32f0dda59d4b41655e67349
Cr-Commit-Position: refs/heads/master@{#374964}